docs: clarify SPA navigation setup with locationWatcher.run()#2380
Open
mrumerf wants to merge 3 commits into
Open
docs: clarify SPA navigation setup with locationWatcher.run()#2380mrumerf wants to merge 3 commits into
mrumerf wants to merge 3 commits into
Conversation
Added the missing `ctx.locationWatcher.run()` call to the SPA navigation example. The `wxt:locationchange` event only fires after the location watcher is started, which was not previously shown in the documentation.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
docs: fix formatting
mrumerf
commented
May 16, 2026
Author
mrumerf
left a comment
There was a problem hiding this comment.
Applied the required formatting fixes and updated the PR.
Collaborator
Still doesn't work |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
==========================================
+ Coverage 78.36% 78.41% +0.05%
==========================================
Files 133 133
Lines 3882 3882
Branches 875 875
==========================================
+ Hits 3042 3044 +2
+ Misses 751 750 -1
+ Partials 89 88 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing
ctx.locationWatcher.run()call to the SPA navigation example.The
wxt:locationchangeevent only fires after the location watcher is started, which was not previously shown in the documentation.Overview
Adds the missing
ctx.locationWatcher.run()call to the SPA navigation documentation and examples.Previously, the docs showed how to listen for the
wxt:locationchangeevent, but did not mention that the location watcher must first be started withctx.locationWatcher.run(). Without this call, the event is never dispatched.Manual Testing
console.loginside thewxt:locationchangelistener.ctx.locationWatcher.run().Related Issue
N/A