fix(qoder): omit scalar answer key for AskUserQuestion strict schema - #301
Open
ri-char wants to merge 1 commit into
Open
fix(qoder): omit scalar answer key for AskUserQuestion strict schema#301ri-char wants to merge 1 commit into
ri-char wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Qoder CLI agent asks the user a question and the user answers from the CodeIsland popup, the CLI rejects the hook response with:
params must NOT have additional propertiesFixed #300.
Root cause
Qoder CLI re-validates
hookSpecificOutput.decision.updatedInputagainst the AskUserQuestion tool schema using Ajv (theparamsprefix comes fromerrorsText({ dataVar: "params" })). That schema isadditionalProperties: falseand only allowsquestions/answers/annotations/metadata.CodeIsland's
askUserQuestionUpdatedInputalso injects a scalaranswerkey alongsideanswers, which trips the strict validation and voids the whole answer.Changes
AppState.isQoderEvent(mirrors the existingisZcodeEventpattern) to detectqoder/qoder-clisources via_source.answerinjection for Qoder sources inaskUserQuestionUpdatedInput; answers flow through the schema-allowedanswersdict keyed by question text, which Qoder remaps correctly. Other CLIs keep the existing behavior.