Open
Conversation
The current implementation allows more dynamic, complex and circularly dependent definitions for the application settings by decoupling category definitions from the settings class * shapeflow.core.settings defines settings: Settings * other modules create Category subclasses (~pydantic) * settings are loaded from JSON * stored in the instance under settings._loaded * when a new category is added, check whether it has an entry in settings._loaded. If it does, initialize the category with that state * requests for settings ~ settings.get(SomeCategory) * returns the instance of this category stored in settings * if this category doesn't exist yet, an instance is added to settings
ybnd
force-pushed
the
dev/setting-default-config
branch
from
fc22ec0 to
7e42b3b
Compare
ybnd
force-pushed
the
main
branch
8 times, most recently
from
2cf281f to
4195d86
Compare
ybnd
force-pushed
the
main
branch
4 times, most recently
from
70196b7 to
13c6b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #25
shapeflow/__init__.pySettingsSettings