Skip to content

Conversation

@ctron
Copy link
Contributor

@ctron ctron commented Dec 13, 2023

Description

Explains a workaround for #3256

Checklist

  • I have reviewed my own code

@ctron ctron force-pushed the feature/doc_if_type_1 branch 2 times, most recently from f4b1769 to 1d5f226 Compare December 13, 2023 08:53
@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Visit the preview URL for this PR (updated for commit 23debb4):

https://yew-rs--pr3560-feature-doc-if-type-hu7h7tdk.web.app

(expires Wed, 20 Dec 2023 09:24:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ctron ctron force-pushed the feature/doc_if_type_1 branch from 1d5f226 to 7d368a5 Compare December 13, 2023 09:02
@ctron ctron force-pushed the feature/doc_if_type_1 branch from 7d368a5 to 23debb4 Compare December 13, 2023 09:17
@ctron
Copy link
Contributor Author

ctron commented Dec 19, 2023

Is there something missing for this PR? It's a doc only change and should be quick to merge.

@futursolo
Copy link
Member

futursolo commented Dec 19, 2023

Thank you for your pull request.

However, I do not think this pull request will be accepted due to the issue with typed children and ChildrenRenderer itself, which is discussed in detail in #3256 and #3262.
As a result, we have committed to remove Children* from most examples and no longer recommend their usage.

You can try out a slightly modified version of the code you submitted in:
https://play.yew.rs/?shared=j98egT98b67VRJAGJIJu

2023-12-19.18.32.11.mov

The correct behaviour should be the input containing 3 being removed and added, however, input 1 is being toggled instead.

@ctron
Copy link
Contributor Author

ctron commented Dec 19, 2023

So, what's the strategy on having type safe children in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants