Draft
Conversation
Biblica license requires all footnotes be included and accessible. usePassage previously defaulted include_notes=false, actively suppressing footnotes the API would otherwise return for chapters. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biblica license requires all footnotes be included and accessible. usePassage previously defaulted include_notes=false, actively suppressing footnotes the API would otherwise return for chapters.
So what this solves is when people use our BibleTextView component, then footnotes will appear, and this will please Biblica. What this does not do is make it where if someone's using our usePassage hook and gets HTML back, it does not make it where that HTML renders a proper footnote yet. Long story short, the HTML doesn't come back in a popover-friendly way. So it can't be rendered without some sort of JavaScript in a popover way. So there still remain issues on that end, that the user, if they get this HTML, will have to figure out how in the world to properly style things, which is why we point people to BibleTextView, but nevertheless, it's still an option on the usePassage.