Update NDArrayLike typing for NumPy 2.0 compatibility (fixes #3780)#3809
Open
abishop1990 wants to merge 2 commits intozarr-developers:mainfrom
Open
Update NDArrayLike typing for NumPy 2.0 compatibility (fixes #3780)#3809abishop1990 wants to merge 2 commits intozarr-developers:mainfrom
abishop1990 wants to merge 2 commits intozarr-developers:mainfrom
Conversation
Methods that transform arrays (reshape, view, astype, copy, transpose, ravel) now correctly return NDArrayLike instead of Self to accurately represent shape and dtype changes in NumPy 2.0+ typing.
Contributor
Author
|
Failing error here seems to be on a bad gateway installing hatch, not sure it's an actual issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
NDArrayLikeProtocol to correctly represent NumPy 2.0+ typing for array transformations.Changes
Methods that transform arrays now return
NDArrayLikeinstead ofSelf:reshape- changes shapeview- changes dtypeastype- changes dtypecopy- returns new instancetranspose- changes shaperavel- flattens to 1DThis aligns with NumPy 2.0's stricter typing system that better represents shape and dtype transformations.
Testing
✅ All 5372 tests pass
✅ All lint checks pass
✅ No type checking errors
Fixes #3780