feat: Add public types for metadata objects (fixes #3795)#3812
Closed
abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
Closed
feat: Add public types for metadata objects (fixes #3795)#3812abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
Conversation
Expose metadata types as public API from the main zarr module: - ArrayV2Metadata and ArrayV3Metadata from zarr.core.metadata - GroupMetadata, ImplicitGroupMarker, and ConsolidatedMetadata from zarr.core.group - ChunkGrid and RegularChunkGrid from zarr.core.chunk_grids - ChunkKeyEncoding, DefaultChunkKeyEncoding, and V2ChunkKeyEncoding from zarr.core.chunk_key_encodings These types can now be imported directly from zarr for better type hints and API clarity. Also add __all__ exports to zarr.core.group to explicitly declare public types.
Contributor
|
IMO these classes are not ready to be made public. they require a range of internal design changes first. |
Contributor
Author
Understood, closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports metadata types as public API.
All validation passed locally (5372 tests).