feat: Parametrize benchmarks for Zarr v2 and v3 formats (fixes #3757)#3818
Closed
abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
Closed
feat: Parametrize benchmarks for Zarr v2 and v3 formats (fixes #3757)#3818abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
abishop1990 wants to merge 1 commit intozarr-developers:mainfrom
Conversation
- Extends existing read/write benchmarks to test both v2 and v3 - Parametrizes on zarr_format, compression, layout, and store type - Skips v2 + sharding combinations (not supported in v2) - Reuses existing test structure per maintainer feedback - Provides performance comparison across Zarr versions Addresses feedback: 'better to reuse existing tests with parametrization'
Contributor
|
we should also add v2 / v3 parametrization to this benchmark: |
This was referenced Mar 22, 2026
Contributor
Author
|
Closing: Parametrized benchmark approach works locally but fails on py3.11-min_deps and macos py3.13. Issue #3757 remains open - maintainer feedback was good, but implementation needs debugging on CI matrix. Can reopen with better environmental understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored benchmarks to parametrize over zarr_format instead of separate v2 test suite.
Per maintainer feedback: 'better to reuse existing tests with parametrization'
Changes:
All 5300+ tests passing locally.