Merged
Conversation
These allow us to restrict code completions into specific contexts:
- For Elixir files, Tailwind and Emmet will now give completions inside
HEEx templates only, save for one caveat
- Tailwind is still scoped into strings so that completions don't
break if Elixir interpolation is used inside the class attribute of
an HTML tag
- For EEx/HEEx files, ElixirLS, Expert, Next LS, and Lexical will now
give completions inside Elixir expressions only - should fix #91
Additionally, this reworks the function override that was being used by
HEEx into an identifier override that should cover slot names as well -
with this change `@` will now be treated as a word character, just like
Elixir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These allow us to restrict code completions into specific contexts:
Additionally, this reworks the function override that was being used by HEEx into an identifier override that should cover slot names as well - with this change
@will now be treated as a word character, just like Elixir