Conversation
ikskuh
left a comment
ikskuh
left a comment
There was a problem hiding this comment.
I have one nitpick. Just give me a heads up if you've changed it or if there's no way to change it.
| while (true) { | ||
| _ = try self.reader.streamDelimiterLimit(writer, '\n', .limited(4096)); | ||
| try writer.flush(); | ||
| { |
There was a problem hiding this comment.
I think the Io.Writer.Allocating can be reused here as well, we don't have to use the ArrayList roundtrip here
There was a problem hiding this comment.
Changed in 68228a2
This avoids the ArrayList roundtrip in the parser loop.
There was a problem hiding this comment.
Please drop the ArrayList completely. We don't need it when we can use the Writer.Allocating in the first place.
It's just a deprecated pattern now
There was a problem hiding this comment.
I replaced the ArrayList with Writer.Allocating.
As a result, the Parser struct no longer needs to store an allocator after init, and has been removed.
2 participants
Migrates the project to Zig 0.16.0.
@cImportwith a translate-c step inbuild.zig.std.IoAPIs.