fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context by andrew-eldridge · Pull Request #9335 · Azure/LogicAppsUX

andrew-eldridge · 2026-07-01T01:54:47Z

Commit Type

feature - New functionality
fix - Bug fix
refactor - Code restructuring without behavior change
perf - Performance improvement
docs - Documentation update
test - Test-related changes
chore - Maintenance/tooling

Risk Level

Low - Minor changes, limited scope
Medium - Moderate changes, some user impact
High - Major changes, significant user/system impact

What & Why

Updates 'isCodeful' checks to use the WORKFLOW_CODEFUL_ENABLED app setting as source of truth rather than csproj content, which is a less reliable/standard indicator.

Impact of Change

Users: May fix codeful project detection in some edge case scenarios
Developers: Removes code for redundant telemetry and extension context
System: N/A

Test Plan

Unit tests added/updated
E2E tests added/updated
Manual testing completed
Tested in:

Contributors

@andrew-eldridge

…orkflows

github-actions · 2026-07-01T01:55:11Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context
Issue: None — the title is specific, descriptive, and matches the scope of the changes.
Recommendation: No change needed.

✅ Commit Type

Properly selected (fix).
Only one commit type is checked, which is correct.

⚠️ Risk Level

The submitted risk level is Low, but the diff touches multiple code paths across command handling, local settings generation, startup logic, and shared utilities. That scope is broader than a minor change.
Recommendation: Update the PR risk label/body to Medium unless your team explicitly treats this kind of cross-cutting internal behavior change as low risk.

✅ What & Why

Current: Updates 'isCodeful' checks to use the WORKFLOW_CODEFUL_ENABLED app setting as source of truth rather than csproj content, which is a less reliable/standard indicator.
Issue: None — concise and clear.
Recommendation: No change needed.

⚠️ Impact of Change

The section is present and gives a reasonable summary, but it could be a bit more explicit about the behavior change in local settings generation and design-time/startup flows.
Recommendation:
- Users: Mention that codeful project detection and publish/build behavior now rely on WORKFLOW_CODEFUL_ENABLED, which may change whether projects are treated as codeful in some cases.
- Developers: Mention the cleanup of deprecated telemetry/context and the rename from csproj-based detection to settings-based detection.
- System: Mention any impact on startup/design-time local settings generation and monitoring view unit-test support gating.

✅ Test Plan

Unit tests were added/updated in the diff, which satisfies the test-plan requirement.
Manual testing is also checked, which is fine.
No failure here because automated tests are present.

⚠️ Contributors

A contributor is listed (@andrew-eldridge), which is good.
Recommendation: No required change, though if others helped with design/review, consider adding them for credit.

✅ Screenshots/Videos

No screenshots are required for this change; it is not a visual/UI-focused change.
Blank is acceptable here.

Summary Table

Section	Status	Recommendation
Title	✅	No change needed
Commit Type	✅	No change needed
Risk Level	⚠️	Update to `Medium` to better match the scope
What & Why	✅	No change needed
Impact of Change	⚠️	Add a little more specificity about affected flows
Test Plan	✅	No change needed
Contributors	✅	Optional: add any additional contributors
Screenshots/Videos	✅	No change needed

Overall: the PR body mostly passes, but I recommend raising the risk level to Medium to better reflect the cross-cutting scope of the change.

Last updated: Wed, 01 Jul 2026 21:39:28 GMT

github-actions · 2026-07-01T01:55:11Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context
Issue: No blocking issue. The title is specific and descriptive.
Recommendation: None required.

✅ Commit Type

Properly selected (fix).
Only one commit type is selected, which is correct.

⚠️ Risk Level

The selected risk level is Low, but the diff removes several code paths, telemetry, and extension context behavior across multiple VS Code flows. That is broader than a minor/safe change, so the advised risk is medium.
Recommendation: Update the PR to Medium - Moderate changes, some user impact unless you can further narrow the scope.

✅ What & Why

Current: Updates 'isCodeful' checks to use the WORKFLOW_CODEFUL_ENABLED app setting as source of truth rather than csproj content, which is a less reliable/standard indicator.
Issue: Clear and concise.
Recommendation: None required.

✅ Impact of Change

The section is present and gives reasonable impact coverage.
Recommendation:
- Users: Good as-is.
- Developers: Good as-is.
- System: Good as-is.

✅ Test Plan

Unit tests were added/updated in the diff, which satisfies the test-plan requirement.
Manual testing is also checked, but automated unit coverage is already sufficient.

⚠️ Contributors

Present (@andrew-eldridge).
Recommendation: Consider adding any PM/Designer/peer contributors if applicable, but this is not required.

⚠️ Screenshots/Videos

Not provided.
Recommendation: No action required unless this PR is expected to change UI/visual behavior.

Summary Table

Section	Status	Recommendation
Title	✅
Commit Type	✅
Risk Level	⚠️	Change to `Medium` to better match the scope of the diff
What & Why	✅
Impact of Change	✅
Test Plan	✅
Contributors	✅
Screenshots/Videos	⚠️	Add only if this is intended to document a visual change

Please update the PR risk level to Medium so it matches the breadth of the code changes. The rest of the PR body looks compliant, and the test plan passes because unit tests were updated in the diff.

Last updated: Wed, 01 Jul 2026 01:55:11 GMT

Copilot

Pull request overview

This PR updates the VS Code designer extension’s “codeful” project detection to rely on the WORKFLOW_CODEFUL_ENABLED app setting (from local.settings.json) rather than inferring from .csproj contents, and removes now-redundant context/telemetry plumbing related to codeful workflow file detection.

Changes:

Switches multiple workflows/commands (deploy, create workflow, publish) to use hasCodefulWorkflowSetting(...) as the primary codeful signal.
Removes the editor/workspace scanning logic that tracked codeful workflow C# files via VS Code contexts.
Introduces workflowCodefulEnabledKey and updates code generation to set WORKFLOW_CODEFUL_ENABLED for codeful templates.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
apps/vs-code-designer/src/main.ts	Removes registration of the codeful workflow context listener.
apps/vs-code-designer/src/constants.ts	Adds `workflowCodefulEnabledKey`; removes older redundant constants/context keys.
apps/vs-code-designer/src/app/utils/verifyIsProject.ts	Uses the codeful setting flag to set `isCodeful` context and influence project validation.
apps/vs-code-designer/src/app/utils/extension.ts	Removes workspace scanning + context update utilities for codeful workflow C# files.
apps/vs-code-designer/src/app/utils/codeless/startDesignTimeApi.ts	Updates design-time local settings generation to determine “codeful” status (currently via SDK reference).
apps/vs-code-designer/src/app/utils/codeful.ts	Renames/refines helpers (`hasCodefulSdkReference`) and updates cache invalidation gating.
apps/vs-code-designer/src/app/utils/test/extension.test.ts	Removes tests for deleted context/scanning utilities.
apps/vs-code-designer/src/app/utils/test/codeful.test.ts	Updates tests to validate cache invalidation gating via `local.settings.json` flag.
apps/vs-code-designer/src/app/commands/publishCodefulProject.ts	Switches “is codeful” check to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/deploy/deploy.ts	Switches deploy path branching to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/createWorkflow/createWorkflow.ts	Switches create-workflow metadata inference to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/createWorkflow/createLogicAppWorkflow.ts	Switches create-workflow inference to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/createWorkflow/test/createLogicAppWorkflow.test.ts	Updates mocks/assertions to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts	Writes `WORKFLOW_CODEFUL_ENABLED` via `workflowCodefulEnabledKey` for codeful templates; removes redundant telemetry/setting.
apps/vs-code-designer/src/app/commands/test/publishCodefulProject.test.ts	Updates mocks/assertions to `hasCodefulWorkflowSetting`.
apps/vs-code-designer/src/app/commands/test/commandWebviewWrappers.test.ts	Updates mocks/assertions to `hasCodefulWorkflowSetting`.

…defulDeployTelemetry

github-actions · 2026-07-01T02:08:22Z

📊 Coverage Check

The following changed files need attention:

⚠️ apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppWorkspace.ts - 75% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/appSettings/localSettings.ts - 22% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/codeful.ts - 67% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/utils/verifyIsProject.ts - 43% covered (needs improvement)

Please add tests for the uncovered files before merging.

github-actions · 2026-07-01T18:15:24Z

❌ PR Validation Error

An error occurred while validating your PR. Please try again later or contact the maintainers.

Error: API request failed with status 503

…defulDeployTelemetry

…/v5.970] (#9359) fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context (#9335) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…/v5.961] (#9358) fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context (#9335) Preserve hotfix-only #9232 codeful extension-bundle settings (v5.961) while applying #9335's WORKFLOW_CODEFUL_ENABLED source-of-truth refactor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

andrew-eldridge added 2 commits June 30, 2026 14:32

use WORKFLOW_CODEFUL_ENABLED setting as source of truth for codeful w…

c5ce740

…orkflows

remove redundant telemetry and extension context

19f13d4

andrew-eldridge requested review from Copilot and lambrianmsft July 1, 2026 01:54

Copilot started reviewing on behalf of andrew-eldridge July 1, 2026 01:55 View session

github-actions Bot added pr-validated needs-pr-update and removed needs-pr-update pr-validated labels Jul 1, 2026

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/vs-code-designer/src/app/utils/codeless/startDesignTimeApi.ts

Comment thread apps/vs-code-designer/src/app/utils/codeless/startDesignTimeApi.ts

Comment thread apps/vs-code-designer/src/constants.ts

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

fa6735a

…defulDeployTelemetry

andrew-eldridge added 3 commits June 30, 2026 22:09

fix codeful local.settings.json generation missing codeful setting

766b69e

use workflowCodefulEnabledKey const

141752b

fix linting errors

2638fa0

lambrianmsft added the risk:low Low risk change with minimal impact label Jul 1, 2026

andrew-eldridge removed the needs-pr-update label Jul 1, 2026

github-actions Bot added the pr-validated label Jul 1, 2026

fix build

6d006fc

github-actions Bot added needs-pr-update and removed pr-validated labels Jul 1, 2026

andrew-eldridge removed the needs-pr-update label Jul 1, 2026

github-actions Bot added the pr-validated label Jul 1, 2026

andrew-eldridge enabled auto-merge (squash) July 1, 2026 21:13

andrew-eldridge added 2 commits July 1, 2026 17:36

Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/co…

5fa82ec

…defulDeployTelemetry

fix tests

1a225fa

lambrianmsft approved these changes Jul 1, 2026

View reviewed changes

andrew-eldridge merged commit 1afcdc4 into main Jul 1, 2026
40 checks passed

andrew-eldridge deleted the aeldridge/codefulDeployTelemetry branch July 1, 2026 22:37

This was referenced Jul 2, 2026

fix(vscode): WORKFLOW_CODEFUL_ENABLED source of truth (#9335) [hotfix/v5.961] #9358

Merged

fix(vscode): WORKFLOW_CODEFUL_ENABLED source of truth (#9335) [hotfix/v5.970] #9359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context#9335

fix(vscode): Make codeful setting WORKFLOW_CODEFUL_ENABLED source of truth, remove redundant telemetry/context#9335
andrew-eldridge merged 9 commits into
mainfrom
aeldridge/codefulDeployTelemetry

andrew-eldridge commented Jul 1, 2026 •

edited by lambrianmsft

Loading

Uh oh!

github-actions Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

andrew-eldridge commented Jul 1, 2026 • edited by lambrianmsft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Commit Type

Risk Level

What & Why

Impact of Change

Test Plan

Contributors

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

⚠️ Risk Level

✅ What & Why

⚠️ Impact of Change

✅ Test Plan

⚠️ Contributors

✅ Screenshots/Videos

Summary Table

Overall: the PR body mostly passes, but I recommend raising the risk level to Medium to better reflect the cross-cutting scope of the change.

Uh oh!

github-actions Bot commented Jul 1, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

⚠️ Risk Level

✅ What & Why

✅ Impact of Change

✅ Test Plan

⚠️ Contributors

⚠️ Screenshots/Videos

Summary Table

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Coverage Check

Uh oh!

github-actions Bot commented Jul 1, 2026

❌ PR Validation Error

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrew-eldridge commented Jul 1, 2026 •

edited by lambrianmsft

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading