ci(ward-flow): require journey coverage and preserve artifact findings - #2710
ci(ward-flow): require journey coverage and preserve artifact findings#2710BigSimmo wants to merge 6 commits into
Conversation
The `ui-ward-journeys` job has never run. Its `if:` required `vars.WARD_JOURNEYS_BLOCKING == 'true'`, a repository variable that was never set, so the job always skipped and `pr-required` recorded it as skipped-and-fine. The only lane that did execute these specs, `ui-advisory`, carries `continue-on-error: true`, so a broken ward journey was run, reported, and passed anyway. That is not hypothetical. Three merges on 2026-09-05 turned five ward routes into redirect stubs and moved three modes onto standalone screens. The specs were retargeted twice, each pass repairing what the previous merge broke, and nothing went red at any point. The gate existed for a real reason: making an already-red lane blocking would stop every UI pull request in the repository, well outside Ward Flow. It was to be lifted only against a green run. That run is `npm run test:e2e:ward-journeys` at 42c4dec, `3 skipped, 71 passed`, established before these edits and repeated after them. The three skips are the parked morning-page pair and one forced-colours probe, none of them a failure. The gate was wired in four places and all four move here: - the job's own `if:` - the `pr-required` aggregate's `require_success` condition, which mirrors that `if:` and must move with it - the now-unused `WARD_JOURNEYS_BLOCKING` env binding - its fixture entry in `tests/ci-cache-safety.test.ts`, which pairs with the env binding because the aggregate script runs under `set -u` The aggregate test gains a case pinning the new behaviour: the lane is required on a UI pull request and nowhere else, so a skipped result now fails there and still passes on a non-UI or draft pull request. The workflow comment asserting the inert design as a deliberate safety property is replaced rather than left to contradict the file, and two passages in the ward lead handover are marked superseded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G73MJVonxK9YQK7UCBy5wq
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e7b42290-c8bf-4237-acf0-1748455d975d) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_343b73e5-751a-4642-96ad-0605284c7a3a) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4ee006cb-d1d6-4406-9ac1-87c00cccd5b2) |
Reviewed the Command third-edition build (artifact d821a155) and the third-edition design system (artifact e7f7b6f2) against src/components/ward-management/. Five new rows: P1 Command and the reducer give opposite answers on a prior decline P1 MHA authorisation is overridable, against the standard's own test P2 ten eligibility gates in the mockup, twelve in the engine P2 the standard states 23 wards across 17 sites, its build carries 16 across 9 P2 ward-flow-reducer.ts contradicts itself on capacity_freshness Three updates carrying the mockup evidence onto existing P1 rows, each appended to the recorded detail rather than replacing it: #BAY1TY the prototype hardens the binary sex field in its reconcile check #6DT5K7 the 'suggests nothing' reversal is already built in the mockup #G4YPNE confirmed absent across ~27,500 lines of design surface too Requests only. docs/outstanding-issues.md is untouched and reconciliation runs separately from a dedicated fresh-base branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GH4wXxKZKVaAvaRmqjck88
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_afb355b4-8402-4a21-8919-d0a55ee11535) |
BigSimmo
changed the title
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #16436 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
2 participants
Summary
Consolidates the required Ward Flow browser-journey gate with its artifact follow-ups. Corrects the hospital-authorisation request to distinguish current-location detention from candidate inpatient destination eligibility.
Consolidates #2710 (ffa7bf7), #2758 (e3911f5). Original heads are retained as ancestors; absorbed PRs are closed only after publication is verified.
Verification
npm run test -- tests/ci-cache-safety.test.ts— 45 passed, 16 skipped.npm run check:outstanding-issues— passed, including inbox and snapshot checks.npm run format— passed; formatting committed.git diff --check— passed.Risk and rollout
npm run check:production-readinesson the shared current-base governance integration stopped at six existing privacy release blockers (five pending and one partial). The production-readiness stage did not execute. These approvals remain outstanding.