issues: queue eight ledger requests from the Ward Flow artifact review - #2758
issues: queue eight ledger requests from the Ward Flow artifact review#2758BigSimmo wants to merge 1 commit into
Conversation
Reviewed the Command third-edition build (artifact d821a155) and the third-edition design system (artifact e7f7b6f2) against src/components/ward-management/. Five new rows: P1 Command and the reducer give opposite answers on a prior decline P1 MHA authorisation is overridable, against the standard's own test P2 ten eligibility gates in the mockup, twelve in the engine P2 the standard states 23 wards across 17 sites, its build carries 16 across 9 P2 ward-flow-reducer.ts contradicts itself on capacity_freshness Three updates carrying the mockup evidence onto existing P1 rows, each appended to the recorded detail rather than replacing it: #BAY1TY the prototype hardens the binary sex field in its reconcile check #6DT5K7 the 'suggests nothing' reversal is already built in the mockup #G4YPNE confirmed absent across ~27,500 lines of design surface too Requests only. docs/outstanding-issues.md is untouched and reconciliation runs separately from a dedicated fresh-base branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GH4wXxKZKVaAvaRmqjck88
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8f3f4aaa-6bb7-4363-a66a-c4a293a70c76) |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3911f5b48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Consolidated into #2710 at d2a1622. The complete original head e3911f5 is retained as an ancestor, including its code, tests and audit requests. Closing this duplicate review/CI stream under the authorised consolidation; source branch retained. Current verification and remaining merge prerequisites are recorded on #2710. This closure does not claim that the successor is merged or that its required CI is green. |
Summary
d821a155) and the third-edition design system (e7f7b6f2), againstsrc/components/ward-management/, and queued what the review found as ledger inbox requests.ward-flow-reducer.tsgive opposite answers on whether a recorded reason gets past a prior decline; and Mental Health Act authorisation sits on the overridable side of a split whose own stated test ("a fact about the world is not overridable") suggests it belongs withallocatable_bed. Three P2: the mockup emits ten eligibility gates whereELIGIBILITY_GATEShas twelve, with differences in both directions; the standard's §8.3 states 23 wards across 17 sites while its own reference build carries 16 across 9; andward-flow-reducer.tscontradicts itself oncapacity_freshness, whose classification comment at line 440 calls it a non-overridable world fact whileSUITABILITY_GATESat line 487 lists it as overridable under the owner ruling of 2026-09-02.#BAY1TY(the prototype's reconcile check actively enforces the binary sex field, so a third value cannot be added without breaking the screen's consistency line),#6DT5K7(the "it suggests nothing" reversal is already built, asshortlistFor()ranks every ward for the selected patient),#G4YPNE(confirmed absent across the design surface as well as the code).docs/outstanding-issues.mdis untouched; reconciliation runs separately from a dedicated fresh-base branch, per the ledger write discipline.docs/outstanding-issues-inbox/, 103 insertions, nothing else in the diff.Verification
npm run check:outstanding-issues— the gate that actually covers this change.npx prettier --check .—All matched files use Prettier code style!(whole tree, not just the changed files).npm run verify:pr-local. The change adds inbox request records and touches no executable path, and the ledger write-discipline gate above is the check that covers it. CI's own risk routing is the backstop.npm run verify:uinot applicable: no UI, routing, styling, or browser behaviour changed.Risk and rollout
docs/outstanding-issues.md.Clinical Governance Preflight
The change records clinical-safety questions rather than altering any clinical behaviour, so the boxes below are stated as unchanged rather than re-proved.
#6DT5K7update sharpens an existing SaMD note: that row already flagged that a board which ranks wards for a patient sits closer to clinical decision support than one that records. The update records that such a ranked list now exists in a built artifact rather than only in conversation, which is the reason it is worth the owner seeing.Notes
capacity_freshnessself-contradiction, because the misleading half is the prose comment a reader meets first, and it has already propagated into#Q6WD1M's reconstructed detail.🤖 Generated with Claude Code
https://claude.ai/code/session_01GH4wXxKZKVaAvaRmqjck88
Generated by Claude Code
Note
Low Risk
Additive inbox JSON only; clinical behaviour and the canonical ledger are unchanged until reconcile applies these requests.
Overview
Queues eight immutable ledger inbox requests under
docs/outstanding-issues-inbox/from the Ward Flow Command mockup and third-edition standard review againstward-management.docs/outstanding-issues.mdis not edited; reconciliation stays on a separate branch.Five new issues: two P1 rows flag owner decisions—prior decline is absolute in the mockup but ignored for re-approach in the reducer, and MHA authorisation is treated as overridable despite the standard’s “world fact” test. Three P2 rows cover eligibility gate list drift (mockup vs
ELIGIBILITY_GATES), §8.3 ward/site counts vs CommandUNITS, and a stale comment inward-flow-reducer.tsthat still groupscapacity_freshnesswith non-overridable world facts whileSUITABILITY_GATESlists it as overridable.Three updates append mockup/design evidence to existing rows
#BAY1TY,#6DT5K7, and#G4YPNE(binary sex reconcile, ranked shortlist vs “suggests nothing”, Aboriginal cultural safety gap on the design surface).No application source, schema, or UI changes—documentation queue only.
Reviewed by Cursor Bugbot for commit e3911f5. Configure here.