Add FAIR signposting#860
Add FAIR signposting#860nsemets wants to merge 14 commits intoCenterForOpenScience:feature/pbs-25-24from
Conversation
|
Thank you so much for this reference PR! I'll open some new PRs based on these changes as part of the FAIR Signposting work. |
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
Leaving some notes for myself for later.
| givenName: contributor.givenName, | ||
| familyName: contributor.familyName, | ||
| })), | ||
| signpostingLinks: this.signpostingService.mockSignpostingLinks, |
There was a problem hiding this comment.
Note: Would like to avoid having to call both signpostingService.addSignpostingHeaders() and adding signpostingLinks to the metaTags object. I think my preference going forward would be to remove the signpostingLinks from the metaTags object (since this is going to be a <link> tag) and just have the logic for adding a <link> to the head tag done within the signpostingService.addSignpostingHeaders() function.
| twitterCreator?: DataContent; | ||
| contributors?: DataContent; | ||
| keywords?: DataContent; | ||
| signpostingLinks?: SignpostingLink[]; |
There was a problem hiding this comment.
Note: Similar to the above, I don't think the signpostingLinks needs to be in this metaTagsData interface
| }, | ||
| ]; | ||
|
|
||
| addSignpostingHeaders(): void { |
There was a problem hiding this comment.
Note: Should take some guid value as a parameter and build the href value based on that guid. Will likely need an additional argument to indicate if we want the URL for the metadata linkset
2 participants
Summary of Changes