Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | alarm clock - #1113
Closed
mshayriyesaricicek wants to merge 5 commits into
Closed
Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | alarm clock#1113mshayriyesaricicek wants to merge 5 commits into
mshayriyesaricicek wants to merge 5 commits into
Conversation
mshayriyesaricicek
added
Needs Review
cjyuan
reviewed
Mar 28, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
You missed updating
index.htmlaccording to an instruction inreadme.md. -
Currently, when the input is either 0 or 1, the alarm will sound 1 second afterward (a bit inconsistent).
cjyuan
added
Reviewed
mshayriyesaricicek
added
Needs Review
cjyuan
reviewed
Apr 1, 2026
cjyuan
added
Reviewed
mshayriyesaricicek
added
Needs Review
cjyuan
reviewed
Apr 3, 2026
cjyuan
added
Reviewed
mshayriyesaricicek
added
Needs Review
cjyuan
reviewed
Apr 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
The app is working.
If you have time, I would suggest practice refactoring the code to reduce the amount duplicated code.
Comment on lines
+101
to
+114
| // stops countdown amd stops audio | ||
| if (countdownIntervalId) { | ||
| clearInterval(countdownIntervalId); | ||
| countdownIntervalId = null; | ||
| } | ||
| alarmRunning = false; // mark that alarm is no longer active | ||
| alarmRinging = false; // mark that alarm sound is no longer playing | ||
| pauseAlarm(); // stop audio if it's playing | ||
|
|
||
| const timerDisplay = document.getElementById("timeRemaining"); | ||
| updateTimerDisplay(timerDisplay, 0); | ||
|
|
||
| document.getElementById("alarmSet").value = ""; // clears input field when stopped | ||
| }); |
Contributor
There was a problem hiding this comment.
Why not just call resetAllStates()?
Comment on lines
+46
to
+53
| // Prevent starting a new alarm if one is already running | ||
| if (alarmRunning) { | ||
| alert("Please press Stop before setting a new alarm."); // ensues user cannot set another alarm without stopping the current one first | ||
| return; | ||
| } | ||
| if (alarmRinging) { | ||
| resetAllStates(timerDisplay); // stop previous alarm and reset states | ||
| } |
Contributor
There was a problem hiding this comment.
Could also just always call resetAllStates() without checking any flags. The logic is not quite the same but doing so can simplify the application logic (lesss amount of code).
With one function call, you can remove the codes on line 46-53, 63-66, and you probably won't need alarmRinging and alarmRunning.
Comment on lines
+81
to
+87
| clearInterval(countdownIntervalId); // stops the countdown timer | ||
| countdownIntervalId = null; // resets timer ID | ||
|
|
||
| alarmRunning = false; // mark that alarm is no longer active | ||
| alarmRinging = true; // mark that alarm sound is currently playing | ||
|
|
||
| updateTimerDisplay(timerDisplay, 0); // shows zero time |
Contributor
There was a problem hiding this comment.
Could also consider replacing this code by resetAllStates().
Even though resetAllStates() is doing more than necessary, it's ok to trade slight inefficiency for simplicity.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Created function for alarmclock