Skip to content

Replace old SHERPA/ROMEO references by Open Policy Finder#5493

Open
bram-maegerman wants to merge 2 commits intoDSpace:mainfrom
atmire:w2p-140040_remove-deprecated-sherpa-references
Open

Replace old SHERPA/ROMEO references by Open Policy Finder#5493
bram-maegerman wants to merge 2 commits intoDSpace:mainfrom
atmire:w2p-140040_remove-deprecated-sherpa-references

Conversation

@bram-maegerman
Copy link
Copy Markdown
Contributor

@bram-maegerman bram-maegerman commented Apr 16, 2026

References

Description

This PR changes all references of SHERPA to Jisc Open Policy FInder

Instructions for Reviewers

Local REST changes

Enable Jisc Open Policy Finder in the backend by:

  • Adding an API key
  • Adding the following to the submissions form:
<row>
    <relation-field>
        <relationship-type>isJournalOfVolume</relationship-type>
        <search-configuration>journal</search-configuration>
        <label>Journal</label>
        <hint>Select the journal related to this volume.</hint>
        <externalsources>opfJournal</externalsources>
    </relation-field>
</row>
  • Add <step id="opfPolicies"/> to the JournalVolume submission process in item-submissions.xml

Steps:

  • Go to {ui}/import-external?entity=Journal and confirm you are able to import OPF Journals into your project
  • Add a new JournalVolume Item and confirm you are able to import an OPF Journal as a parent
    • After importing a parent Journal, confirm the policies connected to this Journal show up in the submission form

List of changes in this PR:

  • Changes all references of SHERPA to Jisc Open Policy Finder in all translation files
  • Changes all filenames or variable names that used SHERPA to JISC or OPF

This PR is larger than the recommended < 1000 lines, mainly due to a large number of changes in translation files

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@bram-maegerman bram-maegerman marked this pull request as ready for review April 16, 2026 13:15
@tdonohue tdonohue added high priority integration: Sherpa Romeo Related to integration with Sherpa Romeo labels Apr 16, 2026
@tdonohue tdonohue added this to the 10.0 milestone Apr 16, 2026
@tdonohue tdonohue requested a review from Micheleboychuk April 16, 2026 13:44
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 16, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority integration: Sherpa Romeo Related to integration with Sherpa Romeo port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Sherpa Romeo new name and translations

2 participants