Replace old SHERPA/ROMEO references by Open Policy Finder

src/app/core/submission/models/sherpa-policies-details.model.ts → src/app/core/submission/models/opf-policies-details.model.ts

@@ -1,25 +1,25 @@
 /**
  * An interface to represent an access condition.
  */
-export class SherpaPoliciesDetailsObject {
+export class JiscOpfPoliciesDetailsObject {
 
   /**
-   * The sherpa policies error
+   * The Jisc Open Policy Finder policies error
    */
   error: boolean;
 
   /**
-   * The sherpa policies journal details
+   * The Jisc Open Policy Finder policies journal details
    */
   journals: Journal[];
 
   /**
-   * The sherpa policies message
+   * The Jisc Open Policy Finder policies message
    */
   message: string;
 
   /**
-   * The sherpa policies metadata
+   * The Jisc Open Policy Finder policies metadata
    */
   metadata: Metadata;
 

src/app/core/submission/models/workspaceitem-section-opf-policies.model.ts

@@ -0,0 +1,22 @@
+import { JiscOpfPoliciesDetailsObject } from './opf-policies-details.model';
+
+/**
+ * An interface to represent the submission's item accesses condition.
+ */
+export interface WorkspaceitemSectionJiscOpfPoliciesObject {
+
+  /**
+   * The access condition id
+   */
+  id: string;
+
+  /**
+   * The Jisc Open Policy Finder policies retrievalTime
+   */
+  retrievalTime: string;
+
+  /**
+   * The Jisc Open Policy Finder policies details
+   */
+  opfResponse: JiscOpfPoliciesDetailsObject;
+}

src/app/core/submission/models/workspaceitem-sections.model.ts

@@ -4,7 +4,7 @@ import { WorkspaceitemSectionDuplicatesObject } from './workspaceitem-section-du
 import { WorkspaceitemSectionFormObject } from './workspaceitem-section-form.model';
 import { WorkspaceitemSectionIdentifiersObject } from './workspaceitem-section-identifiers.model';
 import { WorkspaceitemSectionLicenseObject } from './workspaceitem-section-license.model';
-import { WorkspaceitemSectionSherpaPoliciesObject } from './workspaceitem-section-sherpa-policies.model';
+import { WorkspaceitemSectionJiscOpfPoliciesObject } from './workspaceitem-section-opf-policies.model';
 import { WorkspaceitemSectionUploadObject } from './workspaceitem-section-upload.model';
 
 /**
@@ -24,7 +24,7 @@ export type WorkspaceitemSectionDataType
   | WorkspaceitemSectionLicenseObject
   | WorkspaceitemSectionCcLicenseObject
   | WorkspaceitemSectionAccessesObject
-  | WorkspaceitemSectionSherpaPoliciesObject
+  | WorkspaceitemSectionJiscOpfPoliciesObject
   | WorkspaceitemSectionIdentifiersObject
   | WorkspaceitemSectionDuplicatesObject
   | string;

src/app/core/submission/sections-type.ts

@@ -6,7 +6,7 @@ export enum SectionsType {
   CcLicense = 'cclicense',
   CustomUrl = 'custom-url',
   AccessesCondition = 'accessCondition',
-  SherpaPolicies = 'sherpaPolicy',
+  OpfPolicies = 'opfPolicy',
   Identifiers = 'identifiers',
   Collection = 'collection',
   CoarNotify = 'coarnotify',

src/app/core/testing/section-sherpa-policies.service.mock.ts → src/app/core/testing/section-opf-policies.service.mock.ts

@@ -1,9 +1,9 @@
-import { WorkspaceitemSectionSherpaPoliciesObject } from '../submission/models/workspaceitem-section-sherpa-policies.model';
+import { WorkspaceitemSectionJiscOpfPoliciesObject } from '../submission/models/workspaceitem-section-opf-policies.model';
 
-export const SherpaDataResponse = {
-  'id': 'sherpaPolicies',
+export const OpfDataResponse = {
+  'id': 'opfPolicies',
   'retrievalTime': '2022-04-20T09:44:39.870+00:00',
-  'sherpaResponse':
+  'opfResponse':
   {
     'error': false,
     'message': null,
@@ -96,4 +96,4 @@ export const SherpaDataResponse = {
       'inDOAJ': false,
     }],
   },
-} as WorkspaceitemSectionSherpaPoliciesObject;
+} as WorkspaceitemSectionJiscOpfPoliciesObject;

src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/dynamic-lookup-relation-modal.component.spec.ts

@@ -76,8 +76,8 @@ describe('DsDynamicLookupRelationModalComponent', () => {
       hierarchical: false,
     }),
     Object.assign(new ExternalSource(), {
-      id: 'sherpaPublisher',
-      name: 'sherpaPublisher',
+      id: 'opfPublisher',
+      name: 'opfPublisher',
       hierarchical: false,
     }),
   ];
@@ -103,7 +103,7 @@ describe('DsDynamicLookupRelationModalComponent', () => {
       relationshipType: 'isAuthorOfPublication',
       nameVariants: true,
       searchConfiguration: 'personConfig',
-      externalSources: ['orcidV2', 'sherpaPublisher'],
+      externalSources: ['orcidV2', 'opfPublisher'],
     });
     nameVariant = 'Doe, J.';
     metadataField = 'dc.contributor.author';

src/app/submission/objects/submission-objects.effects.ts

@@ -530,11 +530,11 @@ export class SubmissionObjectEffects {
           mappedActions.push(new UpdateSectionDataAction(submissionId, sectionId, sectionData, filteredErrors, sectionErrors));
         }
 
-        // Sherpa Policies section needs to be updated when the rest response section is empty
-        const sherpaPoliciesSectionId = findKey(currentState.sections, (section) => section.sectionType === SectionsType.SherpaPolicies);
-        if (isNotUndefined(sherpaPoliciesSectionId) && isNotEmpty(currentState.sections[sherpaPoliciesSectionId]?.data)
-          && isEmpty(sections[sherpaPoliciesSectionId])) {
-          mappedActions.push(new UpdateSectionDataAction(submissionId, sherpaPoliciesSectionId, null, [], []));
+        // Opf Policies section needs to be updated when the rest response section is empty
+        const opfPoliciesSectionId = findKey(currentState.sections, (section) => section.sectionType === SectionsType.OpfPolicies);
+        if (isNotUndefined(opfPoliciesSectionId) && isNotEmpty(currentState.sections[opfPoliciesSectionId]?.data)
+          && isEmpty(sections[opfPoliciesSectionId])) {
+          mappedActions.push(new UpdateSectionDataAction(submissionId, opfPoliciesSectionId, null, [], []));
         }
 
         // When Duplicate Detection step is enabled, add it only if there are duplicates in the response section data

src/app/submission/sections/sherpa-policies/content-accordion/content-accordion.component.html → src/app/submission/sections/opf-policies/content-accordion/content-accordion.component.html

@@ -3,7 +3,7 @@
     <div class="d-flex">
       <button type="button" class="btn btn-link p-0 me-4" (click)="$event.preventDefault()"
         [attr.aria-expanded]="!collapse.collapsed" aria-controls="collapseExample">
-        {{version.articleVersion | titlecase}} {{ 'submission.sections.sherpa.publisher.policy.version' |
+        {{version.articleVersion | titlecase}} {{ 'submission.sections.jisc.publisher.policy.version' |
         translate
         }}
       </button>
@@ -14,7 +14,7 @@
         {{version.embargo?.units[0]}}</span>
       } @else {
         <span><i class="fas fa-hourglass-half"></i> {{
-      'submission.sections.sherpa.publisher.policy.noembargo' | translate }}</span>
+      'submission.sections.jisc.publisher.policy.noembargo' | translate }}</span>
     }
 
     <span class="m-1 ms-4">
@@ -28,7 +28,7 @@
       </span>
     } @else {
       <span>{{
-      'submission.sections.sherpa.publisher.policy.nolocation' | translate }}</span>
+      'submission.sections.jisc.publisher.policy.nolocation' | translate }}</span>
     }
   </span>
 </div>
@@ -49,14 +49,14 @@
         <div class="row">
           <div class="col-4">
             <p class="m-1"><i class="fas fa-hourglass-half"></i> {{
-          'submission.sections.sherpa.publisher.policy.embargo' | translate }}</p>
+          'submission.sections.jisc.publisher.policy.embargo' | translate }}</p>
         </div>
         <div class="col-6">
           @if (!!version.embargo) {
             <p class="m-1">{{version.embargo.amount}}
             {{version.embargo.units}}</p>
           } @else {
-            <p class="m-1">{{ 'submission.sections.sherpa.publisher.policy.noembargo' | translate }}</p>
+            <p class="m-1">{{ 'submission.sections.jisc.publisher.policy.noembargo' | translate }}</p>
           }
         </div>
       </div>
@@ -65,7 +65,7 @@
       <div class="row">
         <div class="col-4">
           <p class="m-1"><i class="fas fa-certificate"></i> {{
-        'submission.sections.sherpa.publisher.policy.license' | translate }}</p>
+        'submission.sections.jisc.publisher.policy.license' | translate }}</p>
       </div>
       <div class="col-6">
         @for (license of version.licenses; track license) {
@@ -78,7 +78,7 @@
     <div class="row">
       <div class="col-4">
         <p class="m-1"><i class="fas fa-exclamation-circle"></i> {{
-      'submission.sections.sherpa.publisher.policy.prerequisites' | translate }}</p>
+      'submission.sections.jisc.publisher.policy.prerequisites' | translate }}</p>
     </div>
     <div class="col-6">
       @for (prerequisite of version.prerequisites; track prerequisite) {
@@ -91,7 +91,7 @@
   <div class="row">
     <div class="col-4">
       <p class="m-1"><i class="far fa-folder-open"></i> {{
-    'submission.sections.sherpa.publisher.policy.location' | translate }}</p>
+    'submission.sections.jisc.publisher.policy.location' | translate }}</p>
   </div>
   <div class="col-6">
     @for (location of version.locations; track location) {
@@ -104,7 +104,7 @@
   <div class="row">
     <div class="col-4">
       <p class="m-1"><i class="fas fa-tasks"></i> {{
-    'submission.sections.sherpa.publisher.policy.conditions' | translate }}</p>
+    'submission.sections.jisc.publisher.policy.conditions' | translate }}</p>
   </div>
   <div class="col-6">
     @for (condition of version.conditions; track condition) {

src/app/submission/sections/sherpa-policies/content-accordion/content-accordion.component.spec.ts → src/app/submission/sections/opf-policies/content-accordion/content-accordion.component.spec.ts

@@ -4,7 +4,7 @@ import {
   TestBed,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
-import { SherpaDataResponse } from '@dspace/core/testing/section-sherpa-policies.service.mock';
+import { OpfDataResponse } from '@dspace/core/testing/section-opf-policies.service.mock';
 import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
 import { NgbCollapseModule } from '@ng-bootstrap/ng-bootstrap';
 import {
@@ -40,7 +40,7 @@ describe('ContentAccordionComponent', () => {
     component = fixture.componentInstance;
     de = fixture.debugElement;
     component.isCollapsed = false;
-    component.version = SherpaDataResponse.sherpaResponse.journals[0].policies[0].permittedVersions[0];
+    component.version = OpfDataResponse.opfResponse.journals[0].policies[0].permittedVersions[0];
     fixture.detectChanges();
   });
 
@@ -49,13 +49,13 @@ describe('ContentAccordionComponent', () => {
   });
 
   it('should show 2 rows', () => {
-    component.version = SherpaDataResponse.sherpaResponse.journals[0].policies[0].permittedVersions[0];
+    component.version = OpfDataResponse.opfResponse.journals[0].policies[0].permittedVersions[0];
     fixture.detectChanges();
     expect(de.queryAll(By.css('.row')).length).toEqual(2);
   });
 
   it('should show 5 rows', () => {
-    component.version = SherpaDataResponse.sherpaResponse.journals[0].policies[0].permittedVersions[2];
+    component.version = OpfDataResponse.opfResponse.journals[0].policies[0].permittedVersions[2];
     fixture.detectChanges();
     expect(de.queryAll(By.css('.row')).length).toEqual(5);
   });

src/app/submission/sections/sherpa-policies/content-accordion/content-accordion.component.ts → src/app/submission/sections/opf-policies/content-accordion/content-accordion.component.ts

@@ -3,7 +3,7 @@ import {
   Component,
   Input,
 } from '@angular/core';
-import { PermittedVersions } from '@dspace/core/submission/models/sherpa-policies-details.model';
+import { PermittedVersions } from '@dspace/core/submission/models/opf-policies-details.model';
 import { NgbCollapseModule } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
 

src/app/submission/sections/sherpa-policies/metadata-information/metadata-information.component.html → src/app/submission/sections/opf-policies/metadata-information/metadata-information.component.html

@@ -2,7 +2,7 @@
   @if (!!metadata?.id) {
     <div class="row">
       <div class="col-4">
-        <p class="m-1">{{ 'submission.sections.sherpa.record.information.id' | translate }}</p>
+        <p class="m-1">{{ 'submission.sections.jisc.record.information.id' | translate }}</p>
       </div>
       <div class="col-8">
         <p class="m-1">{{metadata.id}}
@@ -13,7 +13,7 @@
   @if (!!metadata?.dateCreated) {
     <div class="row">
       <div class="col-4">
-        <p class="m-1">{{ 'submission.sections.sherpa.record.information.date.created' | translate }}</p>
+        <p class="m-1">{{ 'submission.sections.jisc.record.information.date.created' | translate }}</p>
       </div>
       <div class="col-8">
         <p class="m-1">{{metadata.dateCreated | date: 'd MMMM yyyy H:mm:ss zzzz' }}
@@ -24,7 +24,7 @@
   @if (!!metadata?.dateModified) {
     <div class="row">
       <div class="col-4">
-        <p class="m-1">{{ 'submission.sections.sherpa.record.information.date.modified' | translate }}</p>
+        <p class="m-1">{{ 'submission.sections.jisc.record.information.date.modified' | translate }}</p>
       </div>
       <div class="col-8">
         <p class="m-1">{{metadata.dateModified| date: 'd MMMM yyyy H:mm:ss zzzz' }}
@@ -35,7 +35,7 @@
   @if (!!metadata?.uri) {
     <div class="row">
       <div class="col-4">
-        <p class="m-1">{{ 'submission.sections.sherpa.record.information.uri' | translate }}</p>
+        <p class="m-1">{{ 'submission.sections.jisc.record.information.uri' | translate }}</p>
       </div>
       <div class="col-8">
         <p class="m-1">

src/app/submission/sections/sherpa-policies/metadata-information/metadata-information.component.spec.ts → src/app/submission/sections/opf-policies/metadata-information/metadata-information.component.spec.ts

@@ -4,7 +4,7 @@ import {
   TestBed,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
-import { SherpaDataResponse } from '@dspace/core/testing/section-sherpa-policies.service.mock';
+import { OpfDataResponse } from '@dspace/core/testing/section-opf-policies.service.mock';
 import { TranslateLoaderMock } from '@dspace/core/testing/translate-loader.mock';
 import {
   TranslateLoader,
@@ -37,7 +37,7 @@ describe('MetadataInformationComponent', () => {
     fixture = TestBed.createComponent(MetadataInformationComponent);
     component = fixture.componentInstance;
     de = fixture.debugElement;
-    component.metadata = SherpaDataResponse.sherpaResponse.metadata;
+    component.metadata = OpfDataResponse.opfResponse.metadata;
     fixture.detectChanges();
   });
 

src/app/submission/sections/sherpa-policies/metadata-information/metadata-information.component.ts → src/app/submission/sections/opf-policies/metadata-information/metadata-information.component.ts

@@ -3,7 +3,7 @@ import {
   Component,
   Input,
 } from '@angular/core';
-import { Metadata } from '@dspace/core/submission/models/sherpa-policies-details.model';
+import { Metadata } from '@dspace/core/submission/models/opf-policies-details.model';
 import { TranslateModule } from '@ngx-translate/core';
 
 /**