-
Notifications
You must be signed in to change notification settings - Fork 5
chore: update findable-ui to latest (#4651) #4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 19 requires explicit JSX imports as JSX is no longer globally
available. Added `import { JSX } from "react"` to all files that use
JSX.Element type annotations.
Also added next-env.d.ts to .eslintignore as it is auto-generated
by Next.js 15.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Next.js 15 has native ESM support, so ky no longer needs to be transpiled. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Rename url -> azul_url in project matrix test mocks to match the Azul API response format. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Fixes _jsxDEV is not a function error in CI by matching the pattern used in contentPages.ts instead of hardcoding development: false. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
- Remove duplicate packages from files/package.json that are already in main package.json (unified, remark-parse, remark-rehype, etc.) - Update rehype-stringify from v9 to v10 for unified v11 compatibility - Set NODE_ENV=production in build-anvil-db script to ensure MDX compiles with production JSX runtime instead of development Co-Authored-By: Claude Opus 4.5 <[email protected]>
) Wait for the filter option to be visible before clicking the checkbox to fix flaky test behavior in CI environments with higher latency. Co-Authored-By: Claude Opus 4.5 <[email protected]>
NoopDog
reviewed
Jan 23, 2026
Collaborator
NoopDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
NoopDog
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4651.
This pull request primarily updates test data and code imports to improve consistency and type safety. The most significant change is the replacement of the
urlproperty withazul_urlin test mocks and assertions within theproject-matrix-mapper.test.tsfile, ensuring tests use the correct field. Additionally, several React component files now explicitly import theJSXtype, enhancing type clarity for JSX usage.Test data and assertion updates:
urlproperty withazul_urlin mock objects, test data, and assertions in__tests__/project-matrix-mapper.test.ts, ensuring that tests reference the correct URL field. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Type safety and code clarity improvements:
JSXimports to numerous React component files to clarify usage of JSX types and improve type safety. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Configuration update:
next-env.d.tsto.eslintignoreto prevent linting of auto-generated Next.js type definitions.