MPR slice w/ volume mapper clips#2113
MPR slice w/ volume mapper clips#2113DrewLazzeriKitware wants to merge 5 commits intoKitware:masterfrom
Conversation
|
@floryst There is an example which relies on InteractorStyleMPRSlice, VolumeOutline, which I'm having trouble replicating using sliceHelper. In particular, setUseLabelOutline() seems to have trouble with the way I've approached clipping, which you can see here:
Should I leave InteractorStyleMPRSlice in place for |
|
I think that has to do with intermixed volumes. Though why the other example works, I have no idea. In any case, I would recommend not using the label outline example and instead just use one volume. |
I agree with @floryst that we don't need an example with two volumes, though the gif shows that there is a mismatch between work coordinates of those two datasets, so we should probably investigate the source. We should be able to render two aligned images with different orientations using two of those mappers with clipping. |
d76b628 to
e8cf590
Compare
|
I've removed the VolumeOutline example, and captured the issue here: #2169 The failed CI was a timeout. Is that likely just a transient issue unrelated to this change? I am adding types to this, then should be ready to merge pending CI and review. |
|
Ok types are added and CI passed this time, please review. |
|
The commit should be flagged as BREAKING_CHANGE because it removes existing files/classes |
01c7930 to
dc0eb81
Compare
dc0eb81 to
6fcacff
Compare
|
This is updated and ready for review again. |
6fcacff to
123dfac
Compare
|
I've left the class checks in AbstractMapper but made them more general. I've also changed the removeClippingPlane method to use instances rather than indexes since this is already a breaking change. I'm against changing AbstractMapper more in this PR unless it's related to the original issue of MPR though. |
123dfac to
8d1dc4e
Compare
|
I've split the AbstractMapper changes into this smaller PR: #2186 I'll revisit this once that gets merged. |
8d1dc4e to
45cd175
Compare
|
Since #2186 was merged, I've rebased this on master and it's ready for merge. |
d891e25 to
c41e52c
Compare
To deprecate vtkInteractorStyleMPRSlice I add a helper using two clip planes instead. The included example is similar to vtkInteractorStyleMPRSlice example. re Kitware#1872
BREAKING CHANGE: InteractorStyleMPRSlice has been removed. vtkSliceHelper achieves the same goal with clip planes instead. fix Kitware#1872
c41e52c to
88d880b
Compare
88d880b to
02533b2
Compare
Some features are still not yet supported: - [] display bug when no opaque actors (showDebugActors=false) are rendered. - [] volume mapper should write the plane in depth buffer. - [] volume mapper should render BEFORE the handles
02533b2 to
cd364a8
Compare



PR and Code Checklist
npm run reformatto have correctly formatted codeContext
fix #1872
Added a helper for slicing imagemapper with clip planes and removed vtkStyleInteractorMPRSlice.
The included example is similar to the vtkStyleInteractorMPRSlice example.
Changes