fix(AbstractMapper): Cleanup mapper classes#2186
Merged
floryst merged 1 commit intoKitware:masterfrom Jan 10, 2022
Merged
Conversation
3 tasks
Contributor
Author
Collaborator
|
LGTM |
daker
suggested changes
Dec 3, 2021
| @@ -42,7 +42,7 @@ export interface vtkAbstractMapper extends vtkAbstractMapperBase { | |||
| * Remove clipping plane at index i. | |||
| * @param {Number} i | |||
Collaborator
There was a problem hiding this comment.
Can you also fix the comment and the params?
Contributor
Author
There was a problem hiding this comment.
Thanks good catch. Fixed.
DrewLazzeriKitware
force-pushed
the
abstract-mapper-cleanup
branch
from
2306726 to
aaeac17
Compare
Contributor
|
@DrewLazzeriKitware your AbstractMapper changes should be the desired one in resolving the conflict. |
Added missing class hierarchy for AbstractMapper. Removed extra extend calls from VolumeMapper. BREAKING CHANGE: Changed removeClippingPlane to use instance instead of index.
DrewLazzeriKitware
force-pushed
the
abstract-mapper-cleanup
branch
from
aaeac17 to
c6be4b0
Compare
Contributor
Author
|
@floryst The merge conflict is resolved |
Member
|
LGTM |
daker
approved these changes
Dec 7, 2021
Collaborator
daker
left a comment
daker
left a comment
There was a problem hiding this comment.
The typescript part is good for me.
Collaborator
|
@floryst since it is a BREAKING_CHANGE, I let you merge it when you see fit. |
|
🎉 This PR is included in version 22.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix problems with Mapper classes found during #2113.
Specifically:
macro.objandmacro.algo(once through parent)BREAKING CHANGE:
Changed removeClippingPlane to use instance instead of index.