Remove use of HOME_IS_SHARED in sim configs#3869
Open
Sigma1912 wants to merge 3 commits intoLinuxCNC:masterfrom
Open
Remove use of HOME_IS_SHARED in sim configs#3869Sigma1912 wants to merge 3 commits intoLinuxCNC:masterfrom
Sigma1912 wants to merge 3 commits intoLinuxCNC:masterfrom
Conversation
Contributor
|
Shouldn't there be at least one example config (with an appropriate name) that demonstrates shared home? Maybe one of the simple ones duplicated and shared home enabled so that people know what to do and expect. |
Collaborator
This was mentioned in the issue report too. Maybe it's in here and we haven't spotted it? |
Sigma1912
force-pushed
the
use_home_not_shared
branch
from
fa6d9eb to
27ccff2
Compare
Contributor
Author
|
Thanks for the feedback. I've added the config 'axis/home_is_shared'. |
Contributor
|
Looks good! You can remove: |
Sigma1912
force-pushed
the
use_home_not_shared
branch
from
27ccff2 to
44f0eac
Compare
Using shared limit switches in sim configs creates error messages when trying to rehome.
Sigma1912
force-pushed
the
use_home_not_shared
branch
from
44f0eac to
4975608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using HOME_IS_SHARED causes unnecessary error messages when rehoming in sim configs.
For discussion:
#3779