Repository navigation
hostmot2: bound Ethernet packets and check transfers - #4660
Open
sleepybishop wants to merge 5 commits into
Open
sleepybishop wants to merge 5 commits into
sleepybishop wants to merge 5 commits into
Conversation
Route an empty receive queue through the existing soft-error policy before allocating the receive buffer or touching the socket. A failed queued send clears this queue even though HostMot2 still calls receive. Cover failed and short sends, unchanged destinations, error-limit escalation, user reset, and a successful queued retry with mock I/O.
sleepybishop
marked this pull request as ready for review
October 10, 2026 03:17
Contributor
|
The test cannot run without a writable RIP source tree. It also includes the raw hm2_eth source and needs to link with hostmot2 code just to build. The construct in the test is fragile and the compile step is not guaranteed to be stable. The compiler flags are also wrong with respect to how the normal code is compiled. There is currently no good way to perform tests like this. |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #4488 as requested. Checks Ethernet transfer lengths and queue bounds, reserves packet-trailer space, and resets queued reads after send failures. A separate commit removes stale 7i95/7i95T connector assignments without changing the mapping.
Includes reproducible mock-socket tests. Local build, regression, sanitizer and static-analysis checks pass; Mesa hardware validation remains pending. Keeping this draft for review.