Repository navigation
Add Detailed Timer Icon Modes - #1170
Merged
Merged
Conversation
CryZe
added
enhancement
ChatGPT Codex Connector
LiveSplit One previewBuilt from 9d71905. Updated automatically for this PR and removed when it closes or merges. |
Update livesplit-core to the merged master revision with detailed timer icon modes, automatic icon fitting, and missing-icon space reclamation. Icons can be hidden, span both rows, or occupy only the first row, while timer sizing and placement remain stable through starts and splits. Expose the typed icon display setting in the layout editor through the shared setting value factory and a dedicated selector. Localize the row modes in every supported language and keep fitting and placement in Core so the editor preview and running timer follow the same layout rules.
CryZe
force-pushed
the
detailed-timer-icon-display-mode
branch
from
October 12, 2026 21:14
4ee93fa to
9d71905
Compare
CryZe
marked this pull request as ready for review
October 12, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the detailed timer's icon display setting to the layout editor and update Core to the merged master revision. The editor offers Hidden, Both Rows, and First Row Only, with translated labels in every supported language. Core handles icon fitting and placement, so the editor preview and running timer follow the same rules.
Open the live preview
Icon display modes
Hidden leaves the whole component width available for text. Both Rows places the icon beside both timers. First Row Only places it beside the segment name and attempt timer, leaving the lower row's full width available for comparisons and the segment timer.
These examples use Core's native software renderer with the same run, timer values, fonts, and 360 × 140 component dimensions. The frontend adds a typed setting-value factory and a dedicated selector; it adds no separate sizing settings.
Segments without icons
When a segment has no icon, its name can use the empty icon column. In Both Rows mode, comparison names and times also move left together. Both timers retain their font sizes and positions, and comparison sizing and vertical spacing remain stable.
These screenshots come from the web application in Chromium. Each pair uses the same component dimensions and run-wide space reservations.
Stable fitting through the run
Core reserves space using the expected timer formats, segment names, and comparison times across the run. Starting and splitting keep timer sizing and placement stable. Icons fit the remaining space and first-row icons align with the main timer's fixed numeric center. Times that exceed their expected format can still shrink to fit.
The native animation shows First Row Only on the left and Both Rows on the right, including alternating segments with and without icons.
Validation: ESLint, TypeScript checks, formatting, all 17 preview helper tests, and the optimized preview build pass. Browser checks cover stable starts and splits, missing-icon space reclamation, resizing, all three editor modes, and saved-layout persistence.