Add logical to allow for the fixing the duplicate heterogeneous chemistry reactions in UKCA StratTrop and CRI-Strat2 schemes#433
Draft
Luke Abraham (theabro) wants to merge 7 commits intoMetOffice:mainfrom
Conversation
Draft
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: James Bruten (@james-bruten-mo)
Within UKCA, N2O5 hydrolysis
N2O5 + H2O --> HONO2 + HONO2
is actually covered by 2 separate reactions, H04 and B85. There is actually considerable overlap of these reactions in the troposphere, leading to overcounting.
A fix is to ensure, using the tropospheric mask, that only H04 works in the stratosphere and B85 only works in the troposphere.
This will be controlled with a temporary logical and changes are required to the UKCA (MetOffice/ukca#30) to account for this. This issue was originally identified by Dr Yao Ge (@yg460-cam) in Cambridge.
Initially the logical,
l_fix_ukca_n2o5_h2o, will be hard-coded to .false. in the UKCA interface, as this fix is targetting UKESM2. Later changes will be made to allow for this logical to be passed via namelist.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - um14.1_hetchem_fixes_lfric_apps/run1
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review