Skip to content

fix: auto-continue command execution when auto-approved#11174

Open
JohnBurtt10-bot wants to merge 1 commit intoRooCodeInc:mainfrom
JohnBurtt10-bot:fix/auto-continue-command-output
Open

fix: auto-continue command execution when auto-approved#11174
JohnBurtt10-bot wants to merge 1 commit intoRooCodeInc:mainfrom
JohnBurtt10-bot:fix/auto-continue-command-output

Conversation

@JohnBurtt10-bot
Copy link

@JohnBurtt10-bot JohnBurtt10-bot commented Feb 3, 2026

Summary

  • Fixes command execution not continuing when command_output ask is auto-approved
  • Previously, process.continue() was only called when response was messageResponse, but auto-approval returns yesButtonClicked
  • Now process.continue() is called for any response type, ensuring auto-approved commands continue properly

Test plan

  1. Enable auto-approval for commands
  2. Run a long-running command (e.g., npm run dev)
  3. Verify the "Continue While Running" prompt auto-continues without user interaction

Important

Fixes auto-approved command execution in ExecuteCommandTool.ts by ensuring process.continue() is called for all response types.

  • Behavior:
    • Fixes issue in executeCommandInTerminal() in ExecuteCommandTool.ts where auto-approved commands did not continue execution.
    • Ensures process.continue() is called for any response type, including yesButtonClicked and messageResponse.
  • Testing:
    • Verified by enabling auto-approval and running a long command to check auto-continue functionality.

This description was created by Ellipsis for a281918. You can customize this summary. It will automatically update as commits are pushed.

When command_output ask is auto-approved (e.g., in voice mode or via
non-blocking ask), the process.continue() was only called when response
was "messageResponse". This meant auto-approval with "yesButtonClicked"
would not actually continue the command execution.

Now process.continue() is called for any response type, ensuring
auto-approval works correctly.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 3, 2026
@roomote
Copy link
Contributor

roomote bot commented Feb 3, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The fix correctly addresses the bug where process.continue() was only called for messageResponse but not for yesButtonClicked (auto-approval). Since command_output is a non-blocking ask that gets auto-approved, moving process.continue() outside the conditional ensures commands continue properly.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant