fix: auto-continue command execution when auto-approved#11174
Open
JohnBurtt10-bot wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix: auto-continue command execution when auto-approved#11174JohnBurtt10-bot wants to merge 1 commit intoRooCodeInc:mainfrom
JohnBurtt10-bot wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
When command_output ask is auto-approved (e.g., in voice mode or via non-blocking ask), the process.continue() was only called when response was "messageResponse". This meant auto-approval with "yesButtonClicked" would not actually continue the command execution. Now process.continue() is called for any response type, ensuring auto-approval works correctly.
Contributor
Review complete. No issues found. The fix correctly addresses the bug where Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command_outputask is auto-approvedprocess.continue()was only called when response wasmessageResponse, but auto-approval returnsyesButtonClickedprocess.continue()is called for any response type, ensuring auto-approved commands continue properlyTest plan
npm run dev)Important
Fixes auto-approved command execution in
ExecuteCommandTool.tsby ensuringprocess.continue()is called for all response types.executeCommandInTerminal()inExecuteCommandTool.tswhere auto-approved commands did not continue execution.process.continue()is called for any response type, includingyesButtonClickedandmessageResponse.This description was created by
for a281918. You can customize this summary. It will automatically update as commits are pushed.