Skip to content

fix: auto-continue command execution when auto-approved #11174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnBurtt10-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: auto-continue command execution when auto-approved #11174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core/tools/ExecuteCommandTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,13 @@ export async function executeCommandInTerminal(
const { response, text, images } = await task.ask("command_output", "")
runInBackground = true

// Handle both user clicking "Continue While Running" (yesButtonClicked)
// and user providing a message (messageResponse)
if (response === "messageResponse") {
message = { text, images }
process.continue()
}
// Always continue the process when user responds
process.continue()
} catch (_error) {
// Silently handle ask errors (e.g., "Current ask promise was ignored")
}
Expand Down
Loading