Small fixes for A/B testing from feedback#1258
Open
sethbern wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the A/B assignment logic in the peer-instruction pairing endpoint so students remain in the same experimental condition as their recorded in-person (verbal) partners, even when some partners did not submit a vote for the current question.
Changes:
- Build verbal-discussion clusters using the full recorded
peergroupmembership (not just current answerers). - Persist experiment assignments for all clustered students (including non-voters), so partners always share a condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+719
to
+721
| # Keep the full recorded verbal group, including partners who did | ||
| # not vote on this question. A student stays in the same condition | ||
| # as the people they talked to verbal partner at all become text chat |
Comment on lines
+722
to
725
| grp = set(find_set_containing_string(in_person_groups, p)) | ||
| grp.add(p) | ||
| grp -= clustered | ||
| grp.add(p) |
Comment on lines
+765
to
+766
| # Record every clustered student in their group's condition, including | ||
| # students whos partner did not vote so partners always share a condition |
Member
|
The grammar fixes are an easy accept I think. The only one I have curiosity about is the double call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this with the peer instruction grant group and everything worked as expected. The only change is that students who didn't vote still stay in the same group as the people they talked to. Before, they could accidentally get split up which would not be the desired outcome for the experiment.