Skip to content

Small fixes for A/B testing from feedback #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnmnetp merged 2 commits into from
Jun 26, 2026
+8 −6
Merged

Small fixes for A/B testing from feedback #1258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c764c41
keep verbal partners in the same A/B condition even if a partner didn…
sethbern Jun 25, 2026
1a71faf
Apply suggestions from code review
sethbern Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions bases/rsptx/assignment_server_api/routers/peer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,11 +716,11 @@ def find_set_containing_string(
for p in answerers:
if p in clustered:
continue
grp = {
s
for s in find_set_containing_string(in_person_groups, p)
if s in sid_ans
}
# Keep the full recorded verbal group, including partners who did
# not vote on this question. Students should stay in the same condition
# as their verbal partners so they aren't split into text chat.
grp = set(find_set_containing_string(in_person_groups, p))
grp -= clustered
grp.add(p)
clustered |= grp
clusters.append(sorted(grp))
Expand Down Expand Up @@ -761,8 +761,10 @@ def find_set_containing_string(
# Re-running the experiment will randomize it again so that it can clear any previous assignments to keep one unambiguous group per student.
# Delete + insert now will happen in a single call so re-running stays fast for larger courses.
experiment_id = f"{div_id}_ab"
# Record every clustered student in their group's condition, including
# students whose partner did not vote, so partners always share a condition
assignments = [(sid, 0) for sid in peeps_in_person] + [
(sid, 1) for sid in peeps
(sid, 1) for sid in peeps_in_chat
]
await replace_user_experiment_entries(experiment_id, assignments)

Expand Down
Loading