GH-40742: [R] fix max_rows_per_group must be a positive number#49709
Merged
thisisnic merged 3 commits intoapache:mainfrom May 5, 2026
Merged
GH-40742: [R] fix max_rows_per_group must be a positive number#49709thisisnic merged 3 commits intoapache:mainfrom
thisisnic merged 3 commits intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
Component: R
awaiting committer review
jonkeane
approved these changes
May 5, 2026
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this, one question to make sure my read is accurate, but looks good + easy test!
| if ( | ||
| !missing(max_rows_per_file) && | ||
| missing(max_rows_per_group) && | ||
| max_rows_per_file > 0 && |
Member
There was a problem hiding this comment.
This line max_rows_per_file > 0 is the one condition that was change, yeah? The rest is whitespace?
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 9a0afd9. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Error message due to faulty checking
What changes are included in this PR?
Change checking circumstances
Are these changes tested?
Yes
Are there any user-facing changes?
No
AI usage
Used Claude to generate this - will double check before marking ready for review