Minor: add tests for regexp_replace and capture groups#21413
Merged
alamb merged 1 commit intoapache:mainfrom Apr 6, 2026
Merged
Minor: add tests for regexp_replace and capture groups#21413alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
adriangb
approved these changes
Apr 6, 2026
Contributor
|
I feel like this is a place where black box fuzz tests (against DuckDB? sqlite? postgres?) would probably find bugs if there are any. |
Contributor
Author
Yeah -- that is a good point. |
Contributor
Author
|
Since these are just tests, I will merge them in and we can do any additional improvements as follow ons |
Contributor
|
Very nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As suggested by @adriangb #21379 (comment)
Let's add some additional test coverage as we work to optimize regexp_replace
What changes are included in this PR?
Add some tests
Are these changes tested?
yes
Are there any user-facing changes?
No