branch-4.0: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks #62403#62541
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks #62403#62541github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
…lbacks (#62403) ### What problem does this PR solve? Problem Summary: download_callback() and move_dir_callback() in task_worker_pool.cpp use SnapshotLoader/CloudSnapshotLoader to perform HDFS downloads and file moves, but do not attach the MemTracker to the thread context via SCOPED_ATTACH_TASK. This causes memory orphan check failures when these callbacks allocate memory through HDFS operations, as the allocations are not tracked by any MemTrackerLimiter. The parallel upload_callback() already has SCOPED_ATTACH_TASK correctly. ### Release note Fix: Add SCOPED_ATTACH_TASK(loader->resource_ctx()) in all four missing locations: - download_callback(StorageEngine&): remote_http_download branch - download_callback(StorageEngine&): broker download branch - download_callback(CloudStorageEngine&): cloud download branch - move_dir_callback(StorageEngine&): local move branch
github-actions
bot
requested review from
morningman and
yiguolei
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62403