Skip to content

branch-4.0: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks #62403 #62541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
+4 −0
Open

branch-4.0: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks #62403 #62541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions be/src/agent/task_worker_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,12 +1324,14 @@ void download_callback(StorageEngine& engine, ExecEnv* env, const TAgentTaskRequ
if (download_request.__isset.remote_tablet_snapshots) {
std::unique_ptr<SnapshotLoader> loader = std::make_unique<SnapshotLoader>(
engine, env, download_request.job_id, req.signature);
SCOPED_ATTACH_TASK(loader->resource_ctx());
status = loader->remote_http_download(download_request.remote_tablet_snapshots,
&downloaded_tablet_ids);
} else {
std::unique_ptr<SnapshotLoader> loader = std::make_unique<SnapshotLoader>(
engine, env, download_request.job_id, req.signature, download_request.broker_addr,
download_request.broker_prop);
SCOPED_ATTACH_TASK(loader->resource_ctx());
status = loader->init(download_request.__isset.storage_backend
? download_request.storage_backend
: TStorageBackendType::type::BROKER,
Expand Down Expand Up @@ -1377,6 +1379,7 @@ void download_callback(CloudStorageEngine& engine, ExecEnv* env, const TAgentTas
std::unique_ptr<CloudSnapshotLoader> loader = std::make_unique<CloudSnapshotLoader>(
engine, env, download_request.job_id, req.signature, download_request.broker_addr,
download_request.broker_prop);
SCOPED_ATTACH_TASK(loader->resource_ctx());
status = loader->init(download_request.__isset.storage_backend
? download_request.storage_backend
: TStorageBackendType::type::BROKER,
Expand Down Expand Up @@ -1530,6 +1533,7 @@ void move_dir_callback(StorageEngine& engine, ExecEnv* env, const TAgentTaskRequ
status = Status::InvalidArgument("Could not find tablet");
} else {
SnapshotLoader loader(engine, env, move_dir_req.job_id, move_dir_req.tablet_id);
SCOPED_ATTACH_TASK(loader.resource_ctx());
status = loader.move(move_dir_req.src, tablet, true);
}

Expand Down
Loading