[FLINK-39498][table] Day time interval with unsupported precision should fail in planning time rather than code gen#27979
Open
snuyanzin wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39498][table] Day time interval with unsupported precision should fail in planning time rather than code gen#27979snuyanzin wants to merge 2 commits intoapache:masterfrom
snuyanzin wants to merge 2 commits intoapache:masterfrom
Conversation
…uld fail in planning time rather than code gen
snuyanzin
commented
Apr 20, 2026
| case typeName if YEAR_INTERVAL_TYPES.contains(typeName) => | ||
| DataTypes.INTERVAL(DataTypes.MONTH).getLogicalType | ||
| case typeName if DAY_INTERVAL_TYPES.contains(typeName) => | ||
| if (relDataType.getPrecision > 3) { |
Contributor
Author
There was a problem hiding this comment.
it was wrong precision to check
Collaborator
fhueske
approved these changes
Apr 20, 2026
Contributor
fhueske
left a comment
fhueske
left a comment
There was a problem hiding this comment.
Thanks for the fix @snuyanzin.
+1 to merge!
Au-Miner
reviewed
Apr 21, 2026
| if (relDataType.getScale > 3) { | ||
| throw new TableException( | ||
| s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getPrecision}") | ||
| s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getScale}") |
Contributor
There was a problem hiding this comment.
nits:
s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getScale} (max supported: 3)"
or
s"Fractional second precision ${relDataType.getScale} is not supported for day-time interval types (max supported: 3)"
| } | ||
|
|
||
| @Test | ||
| def testTimestampAddWithUnsupportedPrecision(): Unit = { |
Contributor
There was a problem hiding this comment.
can add testTimestampAddWithSupportedPrecision
add testSqlApi("TIMESTAMPADD(MILLISECOND, 1, timestamp '2016-02-24 12:42:25')", "2016-02-24 12:42:25.001") test is supported.
| assertThatExceptionOfType(classOf[TableException]) | ||
| .isThrownBy( | ||
| () => | ||
| testSqlApi("TIMESTAMPADD(MICROSECOND, 1, timestamp '2016-02-24 12:42:25')", "2016-06-16")) |
Contributor
There was a problem hiding this comment.
.withMessageContaining("not supported")
or
.withMessageContaining("precision is not supported")
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The query like
fails while code generation
at the same ime we have all the data to fail during planning
Brief change log
typefactory
Verifying this change
test added
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation
Was generative AI tooling used to co-author this PR?