Skip to content

[FLINK-39498][table] Day time interval with unsupported precision should fail in planning time rather than code gen #27979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snuyanzin wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −2
Open

[FLINK-39498][table] Day time interval with unsupported precision should fail in planning time rather than code gen #27979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8613d3a
[FLINK-39498][table] Day time interval with unsupported precision sho…
snuyanzin Apr 20, 2026
7bfb465
Apply spotless
snuyanzin Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...able-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,11 @@ object FlinkTypeFactory {
case typeName if YEAR_INTERVAL_TYPES.contains(typeName) =>
DataTypes.INTERVAL(DataTypes.MONTH).getLogicalType
case typeName if DAY_INTERVAL_TYPES.contains(typeName) =>
if (relDataType.getPrecision > 3) {
Copy link
Copy Markdown
Contributor Author

@snuyanzin snuyanzin Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was wrong precision to check

// In INTERVAL getScale tells about fractional second precision
// See org.apache.calcite.sql.SqlIntervalQualifier
if (relDataType.getScale > 3) {
throw new TableException(
s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getPrecision}")
s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getScale}")
Copy link
Copy Markdown
Contributor

@Au-Miner Au-Miner Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:
s"DAY_INTERVAL_TYPES precision is not supported: ${relDataType.getScale} (max supported: 3)"
or
s"Fractional second precision ${relDataType.getScale} is not supported for day-time interval types (max supported: 3)"

}
DataTypes.INTERVAL(DataTypes.SECOND(3)).getLogicalType

Expand Down
13 changes: 13 additions & 0 deletions ...org/apache/flink/table/planner/expressions/validation/ScalarFunctionsValidationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ class ScalarFunctionsValidationTest extends ScalarTypesTestBase {
() => testSqlApi("TIMESTAMPADD(YEAR, 1.0, timestamp '2016-02-24 12:42:25')", "2016-06-16"))
}

@Test
def testTimestampAddWithUnsupportedPrecision(): Unit = {
Copy link
Copy Markdown
Contributor

@Au-Miner Au-Miner Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add testTimestampAddWithSupportedPrecision
add testSqlApi("TIMESTAMPADD(MILLISECOND, 1, timestamp '2016-02-24 12:42:25')", "2016-02-24 12:42:25.001") test is supported.

assertThatExceptionOfType(classOf[TableException])
.isThrownBy(
() =>
testSqlApi("TIMESTAMPADD(MICROSECOND, 1, timestamp '2016-02-24 12:42:25')", "2016-06-16"))
Copy link
Copy Markdown
Contributor

@Au-Miner Au-Miner Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.withMessageContaining("not supported")
or
.withMessageContaining("precision is not supported")


assertThatExceptionOfType(classOf[TableException])
.isThrownBy(
() =>
testSqlApi("TIMESTAMPADD(NANOSECOND, 1, timestamp '2016-02-24 12:42:25')", "2016-06-16"))
}

// ----------------------------------------------------------------------------------------------
// Sub-query functions
// ----------------------------------------------------------------------------------------------
Expand Down