PrettyPrintXMLWriter: handle null lineIndent in constructors

[elharo]

Constructors accepting a String lineIndent parameter document it "can be null" but call lineIndent.toCharArray() without a null check, throwing NullPointerException.

Fixed constructors now fall back to the default indentation (two spaces) when lineIndent is null, and to "\n" when lineSeparator is null — matching the behavior of the constructors that don't take these parameters.

Fixes #381

Commits:

• 581ca4a — Add failing test: PrettyPrintXMLWriter with null lineIndent
• b38df77 — PrettyPrintXMLWriter: handle null lineIndent/lineSeparator in constructors

[Copilot]

Pull request overview

This pull request fixes PrettyPrintXMLWriter constructors that documented nullable lineIndent/lineSeparator but could throw NullPointerException by calling toCharArray() unconditionally, aligning behavior with the default constructors (two-space indent and "\n" line separator).

Changes:

• Update constructor overloads to fall back to DEFAULT_LINE_INDENT when lineIndent is null.
• Update the constructor overload that accepts lineSeparator to fall back to "\n" when lineSeparator is null.
• Add a regression test covering null lineIndent construction.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java	Adds null-handling fallback logic in constructors for lineIndent and lineSeparator.
src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java	Adds a regression test for constructing with null lineIndent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.