Skip to content

PrettyPrintXMLWriter: handle null lineIndent in constructors #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PrettyPrintXMLWriter: handle null lineIndent in constructors #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1934c45
Add failing test: PrettyPrintXMLWriter with null lineIndent
elharo Jul 1, 2026
0f86410
PrettyPrintXMLWriter: handle null lineIndent/lineSeparator in constru…
elharo Jul 1, 2026
25ecd24
Potential fix for pull request finding
elharo Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ public PrettyPrintXMLWriter(Writer writer) {
* @param doctype can be null
*/
public PrettyPrintXMLWriter(PrintWriter writer, String lineIndent, String encoding, String doctype) {
this(writer, lineIndent.toCharArray(), "\n".toCharArray(), encoding, doctype);
this(
writer,
lineIndent != null ? lineIndent.toCharArray() : DEFAULT_LINE_INDENT,
"\n".toCharArray(),
encoding,
doctype);
}

/**
Expand Down Expand Up @@ -135,7 +140,12 @@ public PrettyPrintXMLWriter(Writer writer, String encoding, String doctype) {
*/
public PrettyPrintXMLWriter(
PrintWriter writer, String lineIndent, String lineSeparator, String encoding, String doctype) {
this(writer, lineIndent.toCharArray(), lineSeparator.toCharArray(), encoding, doctype);
this(
writer,
lineIndent != null ? lineIndent.toCharArray() : DEFAULT_LINE_INDENT,
lineSeparator != null ? lineSeparator.toCharArray() : "\n".toCharArray(),
encoding,
doctype);
}

/**
Expand Down
13 changes: 13 additions & 0 deletions src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,19 @@ public void testPrettyPrintXMLWriterWithGivenLineIndenter() throws IOException {
assertEquals(expectedResult(" "), w.toString());
}

@Test
public void testPrettyPrintXMLWriterWithNullLineIndent() throws IOException {
StringWriter sw = new StringWriter();
PrettyPrintXMLWriter writer = new PrettyPrintXMLWriter(sw, (String) null);

writer.startElement(HTML.Tag.HTML.toString());
writeXhtmlHead(writer);
writeXhtmlBody(writer);
writer.endElement(); // Tag.HTML

assertEquals(expectedResult(), sw.toString());
}
Comment thread
Copilot marked this conversation as resolved.

@Test
public void testEscapeXmlAttributeWindows() throws IOException {
// Windows
Expand Down
Loading