WW-2963 fix(core): resolve default-action-ref via wildcard matching#1623
Open
lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
Open
WW-2963 fix(core): resolve default-action-ref via wildcard matching#1623lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
Conversation
When a default-action-ref points to an action name that only exists as a wildcard pattern (e.g. "movie-input" matching "movie-*"), the framework now falls back to wildcard matching after the exact lookup fails. Port of PR #1614 from Struts 7 to Struts 6.x. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WW-2963
default-action-refpoints to an action name that only exists as a wildcard pattern (e.g."movie-input"matching"movie-*"), the framework now falls back to wildcard matching after the exact lookup failsChanges
DefaultConfiguration.java— 3-line addition: wildcard matcher fallback after exactdefaultActionReflookup failsConfigurationTest.java— 3 new tests:testDefaultActionRefWithWildcard,testDefaultActionRefWithExactMatch,testDefaultActionRefWithWildcardNoMatchxwork-sample.xml— 3 new test packages with corresponding namespacesTest plan
./mvnw -pl core test -Dtest=com.opensymphony.xwork2.config.ConfigurationTest— all 21 tests pass./mvnw -pl core clean test🤖 Generated with Claude Code