Skip to content

WW-2963 fix(core): resolve default-action-ref via wildcard matching #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaszlenart wants to merge 1 commit into
base: release/struts-6-8-x
Choose a base branch
from
+44 −0

WW-2963 fix(core): resolve default-action-ref via wildcard matching

47b2767
Select commit
Loading
Failed to load commit list.
Open

WW-2963 fix(core): resolve default-action-ref via wildcard matching #1623

WW-2963 fix(core): resolve default-action-ref via wildcard matching
47b2767
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 12, 2026 in 4m 29s

Quality Gate failed

Failed conditions
24 Security Hotspots
42.6% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 64 in core/src/main/java/com/opensymphony/xwork2/util/classloader/ReloadingClassLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "defaultIfNull"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEmVH9JS2QyFtgoC1&open=AZzhEmVH9JS2QyFtgoC1&pullRequest=1623

Check warning on line 138 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/SmapStratum.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEr9m9JS2QyFtgo0t&open=AZzhEr9m9JS2QyFtgo0t&pullRequest=1623

Check warning on line 240 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/ELParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEtFt9JS2QyFtgpZ8&open=AZzhEtFt9JS2QyFtgpZ8&pullRequest=1623

Check warning on line 230 in core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionInvocation"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEnZJ9JS2QyFtgoOe&open=AZzhEnZJ9JS2QyFtgoOe&pullRequest=1623

Check warning on line 45 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/AstDeferredExpression.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEtEC9JS2QyFtgpXh&open=AZzhEtEC9JS2QyFtgpXh&pullRequest=1623

Check warning on line 90 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/AstIdentifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEtCu9JS2QyFtgpXZ&open=AZzhEtCu9JS2QyFtgpXZ&pullRequest=1623

Check warning on line 151 in core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionProxy"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEqIp9JS2QyFtgoYp&open=AZzhEqIp9JS2QyFtgoYp&pullRequest=1623

Check warning on line 64 in core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "Double" constructor 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEmp49JS2QyFtgoIB&open=AZzhEmp49JS2QyFtgoIB&pullRequest=1623

Check warning on line 98 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/ImplicitTagLibraryInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEsBI9JS2QyFtgo2R&open=AZzhEsBI9JS2QyFtgo2R&pullRequest=1623

Check warning on line 555 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/ELParserTokenManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEtA29JS2QyFtgpV_&open=AZzhEtA29JS2QyFtgpV_&pullRequest=1623

Check warning on line 131 in core/src/test/java/com/opensymphony/xwork2/config/providers/MockConfigurationProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionChainResult"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEp3-9JS2QyFtgoVY&open=AZzhEp3-9JS2QyFtgoVY&pullRequest=1623

Check warning on line 161 in core/src/test/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProviderActionsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "testDefaultClassName" local variable. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEp989JS2QyFtgoWV&open=AZzhEp989JS2QyFtgoWV&pullRequest=1623

Check warning on line 167 in core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStackFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEliQ9JS2QyFtgn6V&open=AZzhEliQ9JS2QyFtgn6V&pullRequest=1623

Check warning on line 267 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/Parser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEsK99JS2QyFtgo9c&open=AZzhEsK99JS2QyFtgo9c&pullRequest=1623

Check warning on line 369 in core/src/main/java/org/apache/struts2/interceptor/debugging/DebuggingInterceptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide the parametrized type for this generic. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEnMl9JS2QyFtgoNs&open=AZzhEnMl9JS2QyFtgoNs&pullRequest=1623

Check warning on line 30 in core/src/main/java/com/opensymphony/xwork2/util/OgnlTextParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEmmZ9JS2QyFtgoHi&open=AZzhEmmZ9JS2QyFtgoHi&pullRequest=1623

Check warning on line 1633 in core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "buildOgnlCache"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhErBr9JS2QyFtgopN&open=AZzhErBr9JS2QyFtgopN&pullRequest=1623

Check warning on line 45 in core/src/test/java/com/opensymphony/xwork2/validator/ValidatorAnnotationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ActionContext"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEqvI9JS2QyFtgoir&open=AZzhEqvI9JS2QyFtgoir&pullRequest=1623

Check warning on line 40 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/runtime/TagHandlerPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make OPTION_MAXSIZE a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEsia9JS2QyFtgpIe&open=AZzhEsia9JS2QyFtgpIe&pullRequest=1623

Check warning on line 105 in core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultConversionFileProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEmvI9JS2QyFtgoJw&open=AZzhEmvI9JS2QyFtgoJw&pullRequest=1623

Check warning on line 919 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/runtime/PageContextImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEskZ9JS2QyFtgpKb&open=AZzhEskZ9JS2QyFtgpKb&pullRequest=1623

Check warning on line 88 in plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/tagplugins/jstl/core/ForEach.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare "beginV" and all following declarations on a separate line. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEsZg9JS2QyFtgpF8&open=AZzhEsZg9JS2QyFtgpF8&pullRequest=1623

Check warning on line 56 in plugins/embeddedjsp/src/main/java/org/apache/struts2/el/parser/AstLiteralExpression.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEtIH9JS2QyFtgpdi&open=AZzhEtIH9JS2QyFtgpdi&pullRequest=1623

Check warning on line 106 in plugins/portlet/src/main/java/org/apache/struts2/portlet/PortletConstants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make RENDER_DIRECT_LOCATION a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhEt-79JS2QyFtgpnX&open=AZzhEt-79JS2QyFtgpnX&pullRequest=1623

Check warning on line 123 in core/src/test/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsCheckerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_struts&issues=AZzhErGg9JS2QyFtgoqi&open=AZzhErGg9JS2QyFtgoqi&pullRequest=1623
View more details on SonarQubeCloud