Allow entity wrappers in entity set and map types (adopted)#24696
Closed
Trashtalk217 wants to merge 19 commits into
Closed
Allow entity wrappers in entity set and map types (adopted)#24696Trashtalk217 wants to merge 19 commits into
Trashtalk217 wants to merge 19 commits into
Conversation
…d-entity-borrow-for-entity-sets-and-maps
Trashtalk217
added
A-ECS
Member
|
@Bluefinger want to re-review this one? |
Contributor
|
Added the tests to the original PR! |
Contributor
Author
|
I'd rather see #18408 merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
See #18408. This was basically already accepted if not for a couple of tests. You can also copy these tests into the other PR if that makes it easier to retrace the git history.
Testing
I've added two tests for
EntityEquivalentHashMapandEntityEquivalentHashSet, to show that using entity wrappers works.