fix: verify native prebuild fixtures - #426
Open
wanxiankai wants to merge 2 commits into
Open
Conversation
kraenhansen
reviewed
Aug 13, 2026
Collaborator
|
Sorry, this needs a rebase now 🙈 |
wanxiankai
force-pushed
the
fix/verify-prebuild-fixtures
branch
from
August 13, 2026 13:22
33ca234 to
2d4f74f
Compare
Author
|
Rebased onto the latest Re-ran:
Everything passes locally. The GitHub Actions workflow is currently awaiting maintainer approval. |
This was referenced Aug 16, 2026
Closed
Collaborator
|
I pushed a few follow-up refinements (moving the Partially generated by Claude Code |
- Replace the Babel-transform-time require.resolve() guard with a check inside isNodeApiModule itself, so the fix lives in the shared utility (also used by findNodeAddonForBindings) instead of duplicating Node's module resolution algorithm via a second, independent code path that could diverge from what Metro actually resolves at runtime. - Verify the Info.plist contents with a zod schema instead of ad hoc "in" checks on an untyped object, matching how the rest of the repo validates untrusted structured data. - Reuse the exported escapeBundleIdentifier instead of re-deriving the bundle-identifier escaping regex inline in the verify script, so the two can't silently drift apart. Closes callstackincubator#424 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q1k6UQJPPaqKEKmnsRUatt
kraenhansen
force-pushed
the
fix/verify-prebuild-fixtures
branch
from
August 16, 2026 18:22
a848741 to
7e212f5
Compare
kraenhansen
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Info.plistand verify its executable and bundle identifier.nodefixture to the Babel plugin testTest plan
pnpm run buildpnpm --filter react-native-node-api test(61 tests passed)pnpm exec eslint packages/host/src/node/babel-plugin/plugin.ts packages/host/src/node/babel-plugin/plugin.test.ts packages/node-addon-examples/scripts/verify-prebuilds.mtspnpm run prettier:checkCloses #424