Skip to content

APIE-1043: Remove broken RTCE topic live test.#3357

Merged
Kostya Linou (linouk23) merged 1 commit into
mainfrom
fix-cli-live-test
May 15, 2026
Merged

APIE-1043: Remove broken RTCE topic live test.#3357
Kostya Linou (linouk23) merged 1 commit into
mainfrom
fix-cli-live-test

Conversation

@linouk23

Copy link
Copy Markdown
Contributor

Bug Fixes

  • Fix broken live_test,all build by removing the RTCE topic live test that referenced undefined identifiers.

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.

What

Applies to: Confluent Cloud.

test/live/rtce_topic_live_test.go (added in #3331 alongside the RTCE control plane commands) references bare region and topicName identifiers that are not declared anywhere in the live test package. As a result, the
live test target fails to compile under the live_test,all build tags (and under live_test,rtce), blocking every live-test group that includes this file.

This PR deletes the broken file so the live-test suite builds and runs again. The corresponding unit/integration tests and mock handlers for RTCE (test/rtce_topic_test.go, test/test-server/rtce_topic_handler.go) are
unchanged. The live test can be reintroduced in a follow-up once the missing test variables/fixtures are added.

Blast Radius

No customer impact — this PR only touches a live_test-tagged file under test/live/ and does not change any shipped CLI code. The only effect is that the RTCE-topic live test no longer runs; coverage for RTCE remains via
the existing unit and integration tests.

Copilot AI review requested due to automatic review settings May 15, 2026 22:52
@linouk23 Kostya Linou (linouk23) requested a review from a team as a code owner May 15, 2026 22:52
@confluent-cla-assistant

Copy link
Copy Markdown

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@linouk23 Kostya Linou (linouk23) changed the title Remove broken RTCE topic live test. APIE-1043: Remove broken RTCE topic live test. May 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a broken RTCE topic live test so the live_test,all and live_test,rtce test targets can compile again without changing shipped CLI behavior.

Changes:

  • Deletes test/live/rtce_topic_live_test.go, which referenced undefined region and topicName identifiers.
  • Leaves existing RTCE mock/integration coverage unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@linouk23 Kostya Linou (linouk23) merged commit f8d9a69 into main May 15, 2026
5 of 6 checks passed
@linouk23 Kostya Linou (linouk23) deleted the fix-cli-live-test branch May 15, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants