APIE-1043: Remove broken RTCE topic live test.#3357
Merged
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR removes a broken RTCE topic live test so the live_test,all and live_test,rtce test targets can compile again without changing shipped CLI behavior.
Changes:
- Deletes
test/live/rtce_topic_live_test.go, which referenced undefinedregionandtopicNameidentifiers. - Leaves existing RTCE mock/integration coverage unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Channing Dong (channingdong)
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
live_test,allbuild by removing the RTCE topic live test that referenced undefined identifiers.Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Applies to: Confluent Cloud.
test/live/rtce_topic_live_test.go(added in #3331 alongside the RTCE control plane commands) references bareregionandtopicNameidentifiers that are not declared anywhere in thelivetest package. As a result, thelive test target fails to compile under the
live_test,allbuild tags (and underlive_test,rtce), blocking every live-test group that includes this file.This PR deletes the broken file so the live-test suite builds and runs again. The corresponding unit/integration tests and mock handlers for RTCE (
test/rtce_topic_test.go,test/test-server/rtce_topic_handler.go) areunchanged. The live test can be reintroduced in a follow-up once the missing test variables/fixtures are added.
Blast Radius
No customer impact — this PR only touches a
live_test-tagged file undertest/live/and does not change any shipped CLI code. The only effect is that the RTCE-topic live test no longer runs; coverage for RTCE remains viathe existing unit and integration tests.