Repository navigation
build(deps): bump github.com/spf13/pflag from 1.0.10 to 1.1.0 - #7635
Conversation
Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.10 to 1.1.0. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.10...v1.1.0) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-version: 1.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
b5a55fa to
f910c08
Compare
pflag 1.1.0 renders boolean flags in usage as --flag[=true|false] (spf13/pflag#453). Regenerate the acceptance goldens and update the cmdgroup usage test accordingly. No other output changes. Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 14 not selected) 37 tests: regression=37 unreleased=0 coverage=0 failing=0
TestAccept/air/config-help: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): TestAccept/air/help: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): TestAccept/air/image-push: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) TestAccept/bundle/debug/DMS=: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): TestAccept/bundle/debug/DMS=true: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) TestAccept/bundle/help/bundle-deploy/DMS=: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) TestAccept/bundle/help/bundle-deploy/DMS=true: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) TestAccept/bundle/help/bundle-deployment-migrate/DMS=: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) TestAccept/bundle/help/bundle-deployment-migrate/DMS=true: branch ✅ | main (4d0e5dc) ❌ | latest (v1.26.0) ❌main (4d0e5dc): latest (v1.26.0): same output as main (4d0e5dc) 28 more failure details omitted, see the full report in the run. |
janniklasrose
left a comment
There was a problem hiding this comment.
please add a changelog entry that boolean flags now accept an optional argument and that the last occurrence wins in case of multiple arguments
| --dry-run[=true|false] Validate the config against the workspace without submitting a run | ||
| --idempotency-key string Return the existing run if this key was already used | ||
| -h, --help help for run | ||
| -h, --help[=true|false] help for run |
There was a problem hiding this comment.
interesting, never seen anyone use --help=false 😅
but i suppose this is useful for things like my-cli-debug-wrapper --debug=false (later flag wins, verified locally)
✅ Integration test reportCommit: c16d5cd
Top 6 slowest tests (at least 2 minutes):
|
pietern
left a comment
There was a problem hiding this comment.
Reviewed pflag 1.1.0 against CLI usage: the only output change is the [=true|false] suffix on boolean flags in help (agreed in #deco-factory). Goldens regenerated and verified to differ only by that suffix and column padding; CI green.
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
| github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 // MIT | ||
| github.com/spf13/cobra v1.10.2 // Apache-2.0 | ||
| github.com/spf13/pflag v1.0.10 // BSD-3-Clause | ||
| github.com/spf13/pflag v1.1.0 // BSD-3-Clause |
There was a problem hiding this comment.
[AI Generated] nit: --flag=false already parsed under v1.0.10 (base cmd/bundle/utils/utils_test.go:31 tests --force-lock=false). Could the requested fragment describe the new [=true|false] help rendering and invalid-value messages instead of new parsing?
❌ Integration test reportCommit: fa7dc9b
107 interesting tests: 89 FAIL, 9 RECOVERED, 8 flaky, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
Bumps github.com/spf13/pflag from 1.0.10 to 1.1.0.
Release notes
Sourced from github.com/spf13/pflag's releases.
... (truncated)
Commits
f8a9906Merge pull request #533 from gdpu11/fix/count-preserve-value-on-errorf3a68a1Merge pull request #534 from gdpu11/fix/native-integer-ranges70f7745fix: reject native integer flag overflow on 32-bit systems2084408test: cover native integer flag bounds on 32-bit systems7d0f377fix: preserve count flag values when parsing failsd26a4dcMerge pull request #526 from dewanshshekhar/fix/text-flag-type-check2d401c7Fix type identification for text flagsfa584baMerge pull request #520 from adenzhou1350/codex/fix-copy-go-string-valuecc9e689Merge upstream master and retain its linter version70f284bMerge pull request #521 from Harshil-1603/fix/string-map-records