Repository navigation
Conversation
pietern
force-pushed
the
pietern/charm-v2/03a-render-split
branch
from
November 17, 2026 22:29
6ba40d3 to
96d0f82
Compare
Collaborator
✅ Integration test reportCommit: e634ad9
Top 38 slowest tests (at least 2 minutes):
|
Contributor
Author
|
/review |
pietern
force-pushed
the
pietern/charm-v2/03a-render-split
branch
from
November 18, 2026 13:07
96d0f82 to
e634ad9
Compare
pietern
force-pushed
the
pietern/charm-v2/03a-render-split
branch
from
November 18, 2026 15:55
e634ad9 to
9e423b9
Compare
Every TUI model's View becomes a one-line wrapper around render(), so the next change can route key handling through the teainput decoder without touching the rendering. libs/apps/prompt gets a Theme alias for the huh theme and its builder is named appkitStyles, which cmd/apps uses through prompt.Theme instead of importing huh types directly. Behaviour is unchanged and no pin golden moves. select keeps its tea.HideCursor in Init: removing it drops one "?25 reset" from TestModesPin_Select, which is a golden change, so that removal waits for the v2 swap that drops tea.HideCursor. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
force-pushed
the
pietern/charm-v2/03a-render-split
branch
from
November 18, 2026 16:07
9e423b9 to
3051f0a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Each TUI model's
View()becomes a one-line wrapper aroundrender():libs/cmdio: prompt, select, spinner and pager.libs/tableview: the table model.cmd/air: the list TUI.libs/apps/promptgets aThemealias for the huh theme and its builder is namedappkitStyles;cmd/appstakesprompt.Themeinstead of importing huh types.Why
The next PRs route key handling through
teainputand move rendering to v2 types. Separatingrender()from the bubbleteaView()lets the key changes and the v2Viewsignature land without touching rendering code. It is a refactor: no behaviour change and no golden change.selectkeepstea.HideCursorinInithere. Removing it drops one?25 resetfromTestModesPin_Select, which is a golden change, so that removal goes into the v2 swap, wheretea.HideCursorno longer exists.Tests
go build ./..., golangci-lint (0 issues), gofmt clean.go testforlibs/cmdio/...,libs/tableview/...,libs/apps/...,cmd/air/...,cmd/apps/...,cmd/aitools/.... Passes.-update. No golden changes.Stack: based on
pietern/charm-v2/02b-logstring-strip.Manual checks for real terminals: none for this PR (refactor).
This pull request and its description were written by Isaac.