Stop reading the valid field from auth profiles - #2190
Open
janniklasrose wants to merge 1 commit into
Open
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
The Databricks CLI is making `auth profiles` a pure config-file listing: it no longer validates credentials, so the `valid` field in the JSON output is going away (see databricks/cli#5216). Drop `ConfigEntry.valid`. It was parsed out of the JSON but never read anywhere, so nothing behavioural changes — this just stops depending on a field that is disappearing. `--skip-validate` is deliberately kept: older CLIs (the extension pins 1.9.0) still validate every profile here, which is slow and can hang on an unreachable host, and newer CLIs accept the flag as a hidden no-op. Passing it stays correct across both. `authType` also keeps working: the CLI infers auth_type from the config file keys, so profile auth types still render in the login wizard. Co-authored-by: Isaac
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Databricks CLI is making
auth profilesa pure config-file listing: it will no longer validate credentials, so thevalidfield in the JSON output is going away (see databricks/cli#5216).Drop
ConfigEntry.valid. It was parsed out of the JSON but never read anywhere, so nothing behavioural changes — this just stops depending on a field that is disappearing.--skip-validateis deliberately kept: older CLIs still validate every profile here, which is slow and can hang on an unreachable host, and newer CLIs accept the flag as a hidden no-op. Passing it stays correct across both.authTypealso keeps working: the CLI infers auth_type from the config file keys, so profile auth types still render in the login wizard.Co-authored-by: Isaac