Skip to content

Stop reading the valid field from auth profiles #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janniklasrose wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop reading the valid field from auth profiles #2190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/databricks-vscode/src/cli/CliWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ export interface ConfigEntry {
workspaceId?: string;
cloud: Cloud;
authType: string;
valid: boolean;
}

export type SyncType = "full" | "incremental";
Expand Down Expand Up @@ -479,6 +478,10 @@ export class CliWrapper {
}

private getListProfilesCommand(): Command {
// Keep --skip-validate: older CLIs still validate every profile here,
// which makes listing slow and can hang on an unreachable host. Newer
// CLIs never validate and accept the flag as a hidden no-op, so passing
// it is correct for both (see databricks/cli#5216).
return {
command: this.cliPath,
args: [
Expand Down Expand Up @@ -544,7 +547,6 @@ export class CliWrapper {
workspaceId: profile.workspace_id,
cloud: profile.cloud,
authType: profile.auth_type,
valid: profile.valid,
});
} catch (e: unknown) {
let msg: string;
Expand Down
Loading