Conversation
| "langchain-text-splitters>=1,<2", | ||
| "langchain-huggingface>=1,<2", | ||
| "langchain-ollama>=1,<2", | ||
| "bitsandbytes>=0.48.2,<1.0; sys_platform == 'linux'", |
There was a problem hiding this comment.
bitsandbytes is needed by langchain-ollama or langchain-huggingface. I don't remember which one, but I added it intentionally (should have left a comment at the time).
Greptile SummaryThis PR removes
Confidence Score: 3/5Not safe to merge as-is — the primary goal (removing torch from base) is not achieved, and documented extras don't match the package definition. Multiple P1 findings: openai-whisper (torch dep) is still in agents/base, a documented
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
base["base extra\n(agents + web + viz)"]
agents["agents extra\n(langchain, openai,\nopenai-whisper ← torch still here)"]
web["web extra\n(fastapi, uvicorn, ffmpeg)"]
viz["visualization extra\n(rerun-sdk, dimos-viewer)"]
perception["perception extra\n(ultralytics, transformers,\nmoondream) — REMOVED from base ✅"]
bitsandbytes["bitsandbytes\n— REMOVED from agents ✅"]
whisper_doc["whisper extra\n(documented in docs,\nbut NOT in pyproject.toml ❌)"]
base --> agents
base --> web
base --> viz
agents -. "removed" .-> bitsandbytes
base -. "removed" .-> perception
whisper_doc -. "missing definition" .-> pyproject["pyproject.toml"]
style bitsandbytes fill:#d4edda,stroke:#28a745
style perception fill:#d4edda,stroke:#28a745
style whisper_doc fill:#f8d7da,stroke:#dc3545
style agents fill:#fff3cd,stroke:#ffc107
|
| | `visualization` | Rerun viewer + bridge | rerun-sdk, dimos-viewer | No | | ||
| | `web` | FastAPI web interface, audio | fastapi, uvicorn, ffmpeg-python | No | | ||
| | `sim` | MuJoCo simulation | mujoco, playground, pygame | No | | ||
| | `whisper` | OpenAI Whisper STT (full, requires torch) | openai-whisper | **Yes** | |
There was a problem hiding this comment.
Documented
whisper extra does not exist
Line 48 documents a whisper extra (openai-whisper, GPU required), but no such extra is defined in pyproject.toml. A user running pip install 'dimos[whisper]' will get an error. Either the whisper extra needs to be added to pyproject.toml (and openai-whisper removed from agents), or this row should be removed from the table.
| |-------|-------------|--------------|------| | ||
| | *(core)* | Transport, streams, CLI, blueprints, occupancy maps | dimos-lcm, numpy, scipy, opencv, open3d, numba, Pinocchio, typer, textual | No | | ||
| | `agents` | LLM agent, speech, tool use | langchain, openai, whisper, anthropic | No | | ||
| | `agents` | LLM agent, speech, tool use | langchain, openai, faster-whisper, anthropic | No | |
There was a problem hiding this comment.
agents key-packages column says faster-whisper, code says openai-whisper
The table on line 43 lists faster-whisper as a key package for the agents extra and marks it "No GPU", but pyproject.toml still lists openai-whisper (which requires torch) in agents. This mismatch will mislead users who expect a torch-free agent install.
Problem
Dropping heavyweight perception from base install. With other PRs, this removes torch from base install.
Also dropping bitsandbytes which doesn't appear to be used anywhere at all?
Also updating the docs now to reflect all those changes.
Breaking Changes
Users wanting perception now need to request it.