fix: guard MoveToStandbyState in async void transition methods#282
Closed
Qian-Cheng-nju wants to merge 1 commit intodotnet:masterfrom
Closed
fix: guard MoveToStandbyState in async void transition methods#282Qian-Cheng-nju wants to merge 1 commit intodotnet:masterfrom
Qian-Cheng-nju wants to merge 1 commit intodotnet:masterfrom
Conversation
Contributor
Author
|
@dotnet-policy-service agree [company="{Nanjing University}"] |
Contributor
Author
|
@dotnet-policy-service agree company="Nanjing University" |
Collaborator
|
|
Contributor
Author
|
You're right — I checked all four state implementations and their DisposeAsyncCore() methods are fully guarded with try-catch-finally. There's no path that can throw. Thanks for the explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for dotNext again!
The three async void state transition methods (MoveToFollowerState, MoveToCandidateState, MoveToLeaderState) call MoveToStandbyState() in their catch blocks as a fallback. If MoveToStandbyState() itself throws (e.g., DisposeAsync failure during UpdateStateAsync), the exception escapes the async void method and crashes the process via the unobserved exception handler.
This wraps each MoveToStandbyState() fallback in a try-catch so the exception is logged instead of crashing.