Skip to content

fix: guard MoveToStandbyState in async void transition methods #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Qian-Cheng-nju wants to merge 1 commit into from
Closed

fix: guard MoveToStandbyState in async void transition methods #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LogMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,4 +348,12 @@ internal static partial class LogMessages
EventName = $"{EventIdPrefix}.{nameof(StandbyStateExitedWithError)}"
)]
public static partial void StandbyStateExitedWithError(this ILogger logger, Exception e);

[LoggerMessage(
EventIdOffset + 43,
LogLevel.Critical,
"Transition to standby state has failed",
EventName = $"{EventIdPrefix}.{nameof(TransitionToStandbyStateFailed)}"
)]
public static partial void TransitionToStandbyStateFailed(this ILogger logger, Exception e);
}
27 changes: 24 additions & 3 deletions src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/RaftCluster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,14 @@ async void IRaftStateMachine<TMember>.MoveToFollowerState(IRaftStateMachine.IWea
catch (Exception e)
{
Logger.TransitionToFollowerStateFailed(e);
await MoveToStandbyState().ConfigureAwait(false);
try
{
await MoveToStandbyState().ConfigureAwait(false);
}
catch (Exception fallbackEx)
{
Logger.TransitionToStandbyStateFailed(fallbackEx);
}
}
finally
{
Expand Down Expand Up @@ -1119,7 +1126,14 @@ async void IRaftStateMachine<TMember>.MoveToCandidateState(IRaftStateMachine.IWe
catch (Exception e)
{
Logger.TransitionToCandidateStateFailed(e);
await MoveToStandbyState().ConfigureAwait(false);
try
{
await MoveToStandbyState().ConfigureAwait(false);
}
catch (Exception fallbackEx)
{
Logger.TransitionToStandbyStateFailed(fallbackEx);
}
}
finally
{
Expand Down Expand Up @@ -1176,7 +1190,14 @@ async void IRaftStateMachine<TMember>.MoveToLeaderState(IRaftStateMachine.IWeakC
catch (Exception e)
{
Logger.TransitionToLeaderStateFailed(e);
await MoveToStandbyState().ConfigureAwait(false);
try
{
await MoveToStandbyState().ConfigureAwait(false);
}
catch (Exception fallbackEx)
{
Logger.TransitionToStandbyStateFailed(fallbackEx);
}
}
finally
{
Expand Down