Clean up selection logic in PropertyTable#1385
Open
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Open
Clean up selection logic in PropertyTable#1385ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
The `PropertyTable` currently only supports the `select(...)` and will throw a `NotImplementedException` when calling `setSelection(...)`. This is because the editor only supports single-selection and because the selection is stored in the `m_activePropertyInfo` field. By replacing this field can be replaced by the model of the currently focused EditPart and by revealing the edit parts in the key/mouse events, both methods can be removed so that the implementation of the base-class is used.
Test Results 2 720 files ±0 2 720 suites ±0 12h 49m 45s ⏱️ - 7m 36s For more details on these failures, see this check. Results for commit 745a0e3. ± Comparison against base commit 23b6007. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PropertyTablecurrently only supports theselect(...)and will throw aNotImplementedExceptionwhen callingsetSelection(...). This is because the editor only supports single-selection and because the selection is stored in them_activePropertyInfofield.By replacing this field can be replaced by the model of the currently focused EditPart and by revealing the edit parts in the key/mouse events, both methods can be removed so that the implementation of the base-class is used.