Enable checksum validation by default in install-gh-aw.sh#26476
Enable checksum validation by default in install-gh-aw.sh#26476
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/00b1b670-531d-4907-9b5a-1e4369ebccc3 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Enables SHA256 checksum verification by default in install-gh-aw.sh so installs validate downloaded binaries unless users explicitly opt out.
Changes:
- Flip default
SKIP_CHECKSUMtofalse(enable checksum validation by default). - Remove the GitHub Actions–specific override since validation is now the default.
- Update header comments/examples to reflect the new default behavior.
Show a summary per file
| File | Description |
|---|---|
| install-gh-aw.sh | Enables checksum validation by default and updates related comments/examples. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| # | ||
| # Examples: | ||
| # ./install.sh # Install latest version | ||
| # ./install.sh v1.0.0 # Install specific version | ||
| # ./install.sh --skip-checksum # Skip checksum validation | ||
| # ./install.sh v1.0.0 --skip-checksum # Install without checksum validation |
There was a problem hiding this comment.
The header usage/examples reference ./install.sh, but this file is install-gh-aw.sh and the script later prints guidance using ./install-gh-aw.sh ... --skip-checksum. To avoid confusing users (especially those downloading this script directly), update the header to consistently use ./install-gh-aw.sh (or explicitly mention that some distributions/actions copy it to install.sh).
See below for a potential fix:
# Usage: ./install-gh-aw.sh [version] [options]
#
# Examples:
# ./install-gh-aw.sh # Install latest version
# ./install-gh-aw.sh v1.0.0 # Install specific version
# ./install-gh-aw.sh v1.0.0 --skip-checksum # Install without checksum validation
|
@copilot review all comments. Mention latest is the latest "stable" |
…t stable Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0030d95c-e4e0-43f3-8fc4-212b7b9220b8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0030d95c-e4e0-43f3-8fc4-212b7b9220b8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in f2d59ef. Addressed both the review comment and your request:
|
|
Hey The PR is well-scoped, clearly described, and follows the project's agentic development process. It looks ready for maintainer review. 🚀
|
Summary
Enable SHA256 checksum validation by default in
install-gh-aw.sh. Previously, checksum validation was skipped by default (SKIP_CHECKSUM=true) with a comment saying it would be enabled in future releases. Since checksums are already generated for every release viascripts/build-release.sh, this change enables the validation immediately.Changes
SKIP_CHECKSUM=falseas the default (wastrue)SKIP_CHECKSUM=falseoverride in the GitHub Actions block (now the default)--skip-checksumexample in the header to show it used with a version argumentBehavior
INPUT_VERSION) had validation enabled--skip-checksumThe underlying checksum download, verification, and failure-handling logic was already fully implemented — this change simply switches the default to use it.